Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates focused on dependency upgrades, solution/project structure, and significant improvements to test coverage for file preview handlers. The most notable changes include updating NuGet package versions, restructuring the solution file, and rewriting and expanding tests for various file preview handlers.
Dependency and Package Updates:
Microsoft.Extensions.DependencyInjectionfrom version 10.0.3 to 10.0.5 inWinQuickLook.App.csprojand updated related entries inpackages.lock.jsonto ensure consistency. [1] [2] [3]Microsoft.Web.WebView2from version 1.0.3800.47 to 1.0.3856.49 inWinQuickLook.Core.csprojand corresponding lock files. [1] [2] [3] [4]Solution and Project Structure:
WinQuickLook.slnxstructure with a new one that groups projects under/src/and/tests/folders for better clarity and maintainability. [1] [2]Test Suite Improvements:
CodeFilePreviewHandler,HtmlFilePreviewHandler, and introduced new tests forFilePreviewHandler,GenericFilePreviewHandler, andSvgFilePreviewHandler. These new tests provide more thorough coverage, including positive/negative cases and behavioral assertions. [1] [2] [3] [4] [5]CodeFilePreviewHandlerandHtmlFilePreviewHandlerto avoid redundancy. [1] [2]FitTotest toFitTo_SizeExceedsLimit_ReturnsScaledSizefor better intent description.