Fix Junit Output

replay_testing/junit_to_xml.py

@@ -113,7 +113,6 @@ def unittest_results_to_xml(*, name='replay_test', test_results=dict) -> ET.Elem
 
     # Set the overall counts on the root `testsuites` element
     test_suites.set('tests', str(total_tests))
-    test_suites.set('successes', str(total_successes))
     test_suites.set('failures', str(total_failures))
     test_suites.set('errors', str(total_errors))
 
@@ -129,7 +128,6 @@ def pretty_log_junit_xml(et: ET.ElementTree, path: Path):
         # Extract high-level information from the testsuites
         testsuites_name = root.attrib.get('name', 'Unnamed Test Suite')
         total_tests = root.attrib.get('tests', '0')
-        total_successes = root.attrib.get('successes', '0')
         total_failures = root.attrib.get('failures', '0')
         total_errors = root.attrib.get('errors', '0')
 
@@ -139,7 +137,6 @@ def pretty_log_junit_xml(et: ET.ElementTree, path: Path):
         # Log high-level summary
         _logger_.info(f'Test Suite: {testsuites_name}')
         _logger_.info(f'Total Tests: {total_tests}')
-        _logger_.info(f'Successes: {total_successes}')
         _logger_.info(f'Failures: {total_failures}')
         _logger_.info(f'Errors: {total_errors}\n')
 

replay_testing/replay_runner.py

@@ -57,12 +57,16 @@ def __init__(self, test_module, *, run_id: Optional[str] = None):
 
         # Print a whole list of env info
         _logger_.info(f'  ENV VARS: {os.environ}')
-        result_base = (
-            Path('test_results')
-            if os.environ.get('CI') or os.environ.get('AMENT_TEST_RESULTS_DIR')
-            else Path(tempfile.gettempdir())
-        )
+
+        result_base = Path('test_results') if os.environ.get('CI') else Path(tempfile.gettempdir())
         self._replay_directory = result_base / 'replay_testing'
+
+        if not os.access(self._replay_directory, os.W_OK):
+            _logger_.error(
+                f'No write permission for directory: {self._replay_directory}. Setting to ./test_results/replay_testing'
+            )
+            self._replay_directory = Path('test_results') / 'replay_testing'
+
         self._replay_results_directory = self._replay_directory / str(self._test_run_uuid)
 
         # Only load previous run fixtures if run_id is truthy
@@ -164,9 +168,6 @@ def filter_fixtures(self) -> list[ReplayFixture]:
         fixture_cls = self._get_stage_class(ReplayTestingPhase.FIXTURES)
         fixture = fixture_cls()
 
-        if not os.access(self._replay_directory, os.W_OK):
-            raise PermissionError(f'No write permission for directory: {self._replay_directory}')
-
         self._replay_results_directory.mkdir(parents=True, exist_ok=True)
 
         # Check for duplicate fixture keys

test/test_junit.py

@@ -53,7 +53,6 @@ def test_unittest_results_to_xml():
     assert root.get('tests') == '2'
     assert root.get('failures') == '0'
     assert root.get('errors') == '0'
-    assert root.get('successes') == '2'
 
     # Check the first testsuite
     testsuite = root.find('testsuite')