Skip to content

Buildfarm Fix #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
troygibb merged 4 commits into from
Oct 15, 2025
Merged

Buildfarm Fix #22

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76a687b
Log env
troygibb Oct 14, 2025
0c42046
Add env
troygibb Oct 14, 2025
e8e01a3
Another go
troygibb Oct 15, 2025
3a87db0
Merge branch 'main' of github.com:polymathrobotics/replay_testing int…
troygibb Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions replay_testing/replay_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,16 @@ def __init__(self, test_module, *, run_id: Optional[str] = None):

# Print a whole list of env info
_logger_.info(f' ENV VARS: {os.environ}')
result_base = (
Path('test_results')
if os.environ.get('CI') or os.environ.get('AMENT_TEST_RESULTS_DIR')
else Path(tempfile.gettempdir())
)

result_base = Path('test_results') if os.environ.get('CI') else Path(tempfile.gettempdir())
self._replay_directory = result_base / 'replay_testing'

if not os.access(self._replay_directory, os.W_OK):
_logger_.error(
f'No write permission for directory: {self._replay_directory}. Setting to ./test_results/replay_testing'
)
self._replay_directory = Path('test_results') / 'replay_testing'

self._replay_results_directory = self._replay_directory / str(self._test_run_uuid)

# Only load previous run fixtures if run_id is truthy
Expand Down Expand Up @@ -164,9 +168,6 @@ def filter_fixtures(self) -> list[ReplayFixture]:
fixture_cls = self._get_stage_class(ReplayTestingPhase.FIXTURES)
fixture = fixture_cls()

if not os.access(self._replay_directory, os.W_OK):
raise PermissionError(f'No write permission for directory: {self._replay_directory}')

self._replay_results_directory.mkdir(parents=True, exist_ok=True)

# Check for duplicate fixture keys
Expand Down
Loading