Skip to content

Conditional rendering testing value of object of forward/backward link#201

Open
jg10-mastodon-social wants to merge 36 commits into
mainfrom
feat/conditional-values
Open

Conditional rendering testing value of object of forward/backward link#201
jg10-mastodon-social wants to merge 36 commits into
mainfrom
feat/conditional-values

Conversation

@jg10-mastodon-social
Copy link
Copy Markdown
Collaborator

@jg10-mastodon-social jg10-mastodon-social commented Apr 18, 2026 •
edited by angelo-v
Loading

Closes #184

  • Add some-value-eq and every-value-eq
  • Add Thing.observeLiterals
  • Support literals for if-property
  • Add (some|every)-value-(gt|gte|lt|lte)
  • Tests have been written
    • all new code is covered by unit tests
    • the happy path of a new feature is covered by an end-to-end test
      • added to pos-switch integration test
    • manual explorative tests have been performed
  • all dependencies are updated to the latest patch version at minimum
  • the CI pipeline passes
  • documentation is up-to-date
    • TSDoc style comments on important functions, properties and events
    • stories for new PodOS elements have been added to storybook
    • Readme.md files of PodOS elements have been re-generated
    • N/A- architectural decisions are documented as an ADR
    • Changelogs are updated according to Keep a Changelog

jg10-mastodon-social
jg10-mastodon-social commented Apr 18, 2026
View reviewed changes
Comment thread elements/src/components/pos-switch/pos-switch.spec.tsx Outdated
`);
});

it('does not render templates when compareValue indicates that some-value-(lt|lte|gt|gte) is not met (numeric)', async () => {
Copy link
Copy Markdown
Collaborator Author

@jg10-mastodon-social jg10-mastodon-social Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we might need more tests here, but I'm not sure how to design them.
I designed these as TDD tests - they all fail if the numbers are treated as strings.

Copy link
Copy Markdown
Collaborator Author

@jg10-mastodon-social jg10-mastodon-social May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now grouped tests, and split out tests specifically of the test method.
I've tried to systematically go through possible combinations of inputs and data, using the it.each approach.

The code is still missing systematic tests of:

  • evaluating values of property and rev with multiple relations
  • evaluating values of property with multiple strings
  • evaluating values of property with multiple numbers

There are ad-hoc tests for this functionality, so given the difficulty in parameterising these combinatorial tests, I suggest we open an issue documenting this gap and merge in the mean time.

Any suggestions are welcome for systematically testing all combinations in the presence of multiple values!

jg10-mastodon-social
jg10-mastodon-social commented Apr 18, 2026
View reviewed changes
Comment thread elements/src/components/pos-switch/pos-switch.spec.tsx Outdated
@jg10-mastodon-social jg10-mastodon-social marked this pull request as ready for review April 27, 2026 00:55
@jg10-mastodon-social jg10-mastodon-social mentioned this pull request Apr 27, 2026
Open
@angelo-v angelo-v force-pushed the feat/conditional-values branch from 25f0fef to 261f92d Compare May 20, 2026 18:12
jg10-mastodon-social and others added 21 commits May 31, 2026 12:20
@jg10-mastodon-social
feat(pos-switch): if-property filters by some-value-eq
9770768
@jg10-mastodon-social
feat(pos-switch): if-rev filters by some-value-eq
aead175
@jg10-mastodon-social
feat(pos-switch): compareValue supports every-value-eq
598bb76
@jg10-mastodon-social
feat(Thing): add basic observeLiterals
1eca2ad
@jg10-mastodon-social
feat(Thing): observeLiterals updates after additions
d0ae499
@jg10-mastodon-social
feat(Thing): observeLiterals pushes updates in groups
205d72a
@jg10-mastodon-social
feat(Thing): observeLiterals ignores statements about other resources
688e391
@jg10-mastodon-social
feat(Thing): observeLiterals does not push if literals have not changed
57e2fd6
@jg10-mastodon-social
feat(pos-switch): if-property takes literals into account
0d9df94
@jg10-mastodon-social
chore(Thing): lint and typecheck
8887377
@jg10-mastodon-social
feat(pos-switch): compareValue supports (some|every)-value-(eq|gt|gte…
a106af2 
…|lt|lte)
@jg10-mastodon-social
feat(pos-switch): compareValue supports numbers
857d5d1
@jg10-mastodon-social
test(pos-switch): add value-based example to integration test
d9c0313
@jg10-mastodon-social
doc(pos-case): add value testing attributes
57bccaa
@jg10-mastodon-social
doc(Thing): add doc string for observeLiterals
fc421db
@jg10-mastodon-social
doc(core): add observeLiterals to changelog
e4e3952
@jg10-mastodon-social
doc(elements): add pos-switch value testing to changelog
101b86c
@jg10-mastodon-social
doc: add pos-switch value testing to storybook
27891d7
@angelo-v @jg10-mastodon-social
refactor: generalize function to observe changes
36ef2e1
@angelo-v @jg10-mastodon-social
test(pos-switch): negation (absense) of property or backward link
afa327b
@angelo-v @jg10-mastodon-social
test(pos-switch): prepare data driven test for several conditions
3d6a895
@jg10-mastodon-social
test(pos-switch): not if-property some-value-eq passes
148570d
@jg10-mastodon-social
test(pos-switch): group tests; extract tests for test method
b58bd02
@jg10-mastodon-social
test(pos-switch): group reactivity tests
3384a2e
@jg10-mastodon-social
test(pos-switch): test if-typeof attribute combinations
83c6eaa
@jg10-mastodon-social
test(pos-switch): handle type checks with multiple values
699f066
@jg10-mastodon-social
test(pos-switch): if-property presence/absence combinatorial tests
fcfa10f
@jg10-mastodon-social
test(pos-switch): if-rev presence/absence combinatorial tests
7fa04f3
@jg10-mastodon-social
test(pos-switch): combinatorial tests for property and rev with singl…
958ffde 
…e relations
@jg10-mastodon-social
test(pos-switch) combinatorial tests for property and rev with no values
bbb8943
@jg10-mastodon-social
test(pos-switch): combinatorial tests for property value with single …
d6b03d6 
…string
@jg10-mastodon-social
test(pos-switch): combinatorial tests for property value with single …
4e5a20a 
…number
@jg10-mastodon-social
chore(core): rebase CHANGELOG
9bbd066
jg10-mastodon-social
jg10-mastodon-social commented May 31, 2026
View reviewed changes
Comment thread core/CHANGELOG.md
and this project adheres to
[Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 0.30.0
Copy link
Copy Markdown
Collaborator Author

@jg10-mastodon-social jg10-mastodon-social May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now 0.30.0, but I may have misunderstood what is in the previous release

jg10-mastodon-social
jg10-mastodon-social commented May 31, 2026
View reviewed changes
Comment thread elements/CHANGELOG.md

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 0.42.0
Copy link
Copy Markdown
Collaborator Author

@jg10-mastodon-social jg10-mastodon-social May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelo-v Is this correct?
When rebasing on main, it looked like your previous fixes no longer applied given the release in the mean time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelo-v angelo-v Awaiting requested review from angelo-v

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conditional rendering testing value of object of forward/backward link

2 participants

@jg10-mastodon-social @angelo-v