Updates ci-cd commands to set node version based on SPFx project version. Closes #6717

[Adam-it]

Closes #6717

[milanholemans]

Really cool enhancement @Adam-it! This will improve the command a lot.
However, while reviewing, I found a few things we should take a look at first.

[Copilot]

Pull Request Overview

This pull request updates CI/CD workflow commands to dynamically determine the Node.js version based on the SharePoint Framework (SPFx) project version rather than using a hardcoded version. The PR refactors shared compatibility data into a separate module and adds logic to compute the appropriate Node.js version from version ranges.

• Extracts SPFx version compatibility matrix to a shared module
• Adds utility function to parse version ranges and determine highest compatible Node.js version
• Updates GitHub workflow and Azure DevOps pipeline commands to set Node.js version dynamically

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/utils/spfx.ts	Added utility function to extract highest Node version from semver range
src/utils/spfx.spec.ts	Added test coverage for the new utility function
src/m365/spfx/commands/spfx-doctor.ts	Removed duplicate compatibility matrix, now imports from shared module
src/m365/spfx/commands/project/project-github-workflow-add.ts	Added logic to determine and set Node version based on SPFx project version
src/m365/spfx/commands/project/project-github-workflow-add.spec.ts	Added test coverage for version determination and error handling
src/m365/spfx/commands/project/project-azuredevops-pipeline-add.ts	Added logic to determine and set Node version based on SPFx project version
src/m365/spfx/commands/project/project-azuredevops-pipeline-add.spec.ts	Added test coverage for version determination and error handling
src/m365/spfx/commands/project/DeployWorkflow.ts	Changed default Node version from hardcoded "22.x" to empty string
src/m365/spfx/commands/SpfxCompatibilityMatrix.ts	New shared module containing SPFx compatibility matrix data

[Adam-it]

@milanholemans I added the first batch of fixes to your comments that I could do without thinking 😁.
As for the rest, I will look into them ASAP. In order to solve them, I need to remind myself how it works and why it works this way, as after such a time gap, I have no idea why some of the code was written this way 😁

[Adam-it]

@milanholemans it took a while, and I do apologize for that. Lately, I have more tasks/work in a day than I can simply manage within 24 hours

[milanholemans]

Hi @Adam-it, seems like we ran into merge conflicts again. Could you have a look? I'll try to get it merged ASAP.

[Adam-it]

Hi @Adam-it, seems like we ran into merge conflicts again. Could you have a look? I'll try to get it merged ASAP.

I will but after we merge the spfx update commands PR done by Waldek as it will also touch the spfx doctor command which I update 👍

[Adam-it]

@milanholemans,
ready 👍

[milanholemans]

I've had another look, and I think we should recheck a few things before we merge it.

[Adam-it]

ready for another round