fix: exitBeforeEnter in useTransition doesn't work when used with trail (#1868) #2407
+38
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61a9853 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1868
What
When
trailandexitBeforeEnterare used together, only the last of the leave transitions was being removed fromexitingTransitions. (See useTransition.tsx:330) On re-render, the other transitions which remained inexitingTransitionsmeant enter animations would not play.Instead I am now clearing each transition as it completes. Essentially I just moved the
delete()statement into thet.phase == TransitionPhase.LEAVEblock so that it runs for every leaving transition rather than waiting for idle.I also added a new test. To verify the fix you can pull this commit, remove the fix, and run the test. It will fail. With the fix in place, it passes. No other tests fail and my visual tests in my app show that things still work.
Checklist
I don't think documentation needs to be updated or a demo needs to be added for this bugfix