Skip to content

test(forge): update sandbox mode assertion to workspace-write for interactive mode #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
plusplusoneplusplus wants to merge 1 commit into from
Closed

test(forge): update sandbox mode assertion to workspace-write for interactive mode #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/forge/test/copilot-sdk-wrapper/codex-sdk-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,15 +537,15 @@
);
});

it('sendMessage starts interactive Codex threads with read-only sandbox', async () => {
it('sendMessage starts interactive Codex threads with workspace-write sandbox', async () => {
const codexMock = svc['sdk'] as ReturnType<typeof makeCodexSdkMock>;

await svc.sendMessage({ prompt: 'ask mode', mode: 'interactive' });

expect(codexMock.startThread).toHaveBeenCalledOnce();
expect(codexMock.startThread.mock.calls[0][0]).toEqual(expect.objectContaining({

Check failure on line 546 in packages/forge/test/copilot-sdk-wrapper/codex-sdk-service.test.ts

View workflow job for this annotation

GitHub Actions / forge-test (ubuntu-latest, 24.x)

test/copilot-sdk-wrapper/codex-sdk-service.test.ts > CodexSDKService — SDK mocked > sendMessage starts interactive Codex threads with workspace-write sandbox 

AssertionError: expected { …(5) } to deeply equal ObjectContaining{…}

- Expected
+ Received

- ObjectContaining {
+ Object {
+   "additionalDirectories": Array [
+     "/home/runner/.coc",
+   ],
    "approvalPolicy": "never",
    "networkAccessEnabled": false,
-   "sandboxMode": "workspace-write",
+   "sandboxMode": "read-only",
+   "skipGitRepoCheck": true,
  }

 ❯ test/copilot-sdk-wrapper/codex-sdk-service.test.ts:546:56

Check failure on line 546 in packages/forge/test/copilot-sdk-wrapper/codex-sdk-service.test.ts

View workflow job for this annotation

GitHub Actions / forge-test (macos-latest, 24.x)

test/copilot-sdk-wrapper/codex-sdk-service.test.ts > CodexSDKService — SDK mocked > sendMessage starts interactive Codex threads with workspace-write sandbox 

AssertionError: expected { …(5) } to deeply equal ObjectContaining{…}

- Expected
+ Received

- ObjectContaining {
+ Object {
+   "additionalDirectories": Array [
+     "/Users/runner/.coc",
+   ],
    "approvalPolicy": "never",
    "networkAccessEnabled": false,
-   "sandboxMode": "workspace-write",
+   "sandboxMode": "read-only",
+   "skipGitRepoCheck": true,
  }

 ❯ test/copilot-sdk-wrapper/codex-sdk-service.test.ts:546:56

Check failure on line 546 in packages/forge/test/copilot-sdk-wrapper/codex-sdk-service.test.ts

View workflow job for this annotation

GitHub Actions / forge-test (windows-latest, 24.x)

test/copilot-sdk-wrapper/codex-sdk-service.test.ts > CodexSDKService — SDK mocked > sendMessage starts interactive Codex threads with workspace-write sandbox 

AssertionError: expected { …(5) } to deeply equal ObjectContaining{…}

- Expected
+ Received

- ObjectContaining {
+ Object {
+   "additionalDirectories": Array [
+     "C:\\Users\\runneradmin\\.coc",
+   ],
    "approvalPolicy": "never",
    "networkAccessEnabled": false,
-   "sandboxMode": "workspace-write",
+   "sandboxMode": "read-only",
+   "skipGitRepoCheck": true,
  }

 ❯ test/copilot-sdk-wrapper/codex-sdk-service.test.ts:546:56
approvalPolicy: 'never',
sandboxMode: 'read-only',
sandboxMode: 'workspace-write',
networkAccessEnabled: false,
}));
});
Expand Down
Loading