pr/b52b3a5f5 add modal job ai selector controls#260
Merged
plusplusoneplusplus merged 12 commits intoJun 2, 2026
Conversation
Owner
plusplusoneplusplus
commented
Jun 2, 2026
plusplusoneplusplus
commented
- Add modal job AI selector controls
- Wire provider effort into generate plan queue
- Wire provider effort into work item execute
- Wire Ralph launch AI selection
- Wire Ralph start AI selection
- Wire Update Document AI selection
- Wire git skill AI selection
- Wire Enqueue dialog AI selection
- Add Enqueue floating chat AI selection regression
Introduce shared modal controls for provider, model, reasoning effort, and effort-tier selection so ad hoc job dialogs can align with New Chat behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add modal AI controls to GenerateTaskDialog and pass provider/model/reasoning-effort through the queue generation hook and route using shared queue validation. Cover passthrough, omission defaults, and invalid provider regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the shared modal AI controls for direct Ralph goal-file launches and pass resolved provider, model, and reasoning effort through the ralph-launch route. Add route and component coverage for reasoning-effort passthrough and no-override behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add shared modal AI controls to the git skill context dialog and pass resolved provider, model, and reasoning effort into queued skill chat tasks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The modal job AI controls (and NewChatArea) persist the selected agent provider to the per-repo preference `lastChatProvider`, but that field was missing from PerRepoPreferencesSchema. Since the schema uses .strip(), the PATCH was silently dropped server-side and provider selection never survived a reload. Add the field to the schema so provider persistence works. Also update the e2e tests that still asserted the legacy persisting model <select> dropdowns to the new chip-based ModalJobAiControls UI: - ai-actions 7.4: assert the update-doc model-picker chip instead of #update-doc-model - preferences 007: rewrite the model/provider suite for the chip UI (ephemeral in-memory model override + persisted provider) and fix the workspace-select locator now that the model <select> is gone. - Re-export ModalJobAiControls from the shared barrel (barrel-completeness). Add regression unit tests covering lastChatProvider schema round-trip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The RALPH_COMPLETE final-check continuity test (AC-02) ended with executor.dispose(), which does not wait for in-flight ralph-session writes (the final-check task and the unrelated exclusive backlog) to settle. On macOS the afterEach rm then raced with a background write into <dataDir>/repos, producing a flaky ENOTEMPTY on rmdir. Switch to drainAndDispose(5000), matching the AC-01 hardening, so all writes complete before the data directory is removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'renders each chunk before the next one arrives' e2e test released the first gated chunk after only observing the /stream request being sent, which precedes the server registering its output subscriber. Any chunk emitted in that pre-subscription window is dropped, causing a flaky empty bubble. Instrument EventSource in the test to observe the server's immediate post-subscribe 'heartbeat' frame and wait for it before releasing the first chunk, guaranteeing deterministic delivery. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
plusplusoneplusplus
deleted the
pr/b52b3a5f5-add-modal-job-ai-selector-controls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.