Allow reads from the OS temp directory#259
Merged
Merged
Conversation
Add os.tmpdir() to the trusted read-only directories so the dashboard can read transient tool-output files (e.g. copilot-tool-output-*.txt) without hitting a 403. Update /api/fs/blob tests to use a home-folder subdir for the untrusted cases and add a temp-dir acceptance test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ew test os.tmpdir() is now a trusted read-only directory, so using it as the 'evil' untrusted path in the preview test caused a 200 instead of 403. Switch to a temp dir under os.homedir() (outside ~/.copilot) which is genuinely outside all trusted roots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…-preview test os.tmpdir() is now a trusted read-only directory, so using it as the 'outside' untrusted path in the image-preview security test caused a 200 instead of 403. Switch to os.homedir() prefix (outside ~/.copilot) which is genuinely outside all trusted roots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.