batch of changes#250
Merged
Merged
Conversation
…ot colors Commit 9492febce removed ProviderBadge from history items in ChatListPane and replaced it with provider-coloured running-task dots. The test file ChatListPane-provider.test.tsx was not updated in that commit. Update all test cases that previously expected a provider-badge to be rendered in history items to instead assert that no badge is rendered (queryByTestId returns null), matching the new behaviour for all providers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract shared helpers for Ralph continue/new-loop route infrastructure, reuse the additional-iteration resolver from final-check gap loops, and add focused utility coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Lift PR title from PrReviewContent to PopOutGitReviewContent via onTitleLoaded callback - Render PR title as a collapsible subtitle row below the PR number in the popout top bar (expanded by default) - Toggle button (chevron) appears only when a title is available; click to collapse/expand - Include PR title in document.title when available - Add data-testids: popout-pr-title-toggle, popout-pr-title-description - Add structural and behaviour tests covering title display, toggle, collapse/expand, and no-title edge cases Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- EffortPillSelector.test.tsx: adds tests for xhigh ('Extra High') option
rendering, selection, onChange dispatching, and model-specific filtering
via buildEffortOptionsForModel; extends buildEffortOptionsForModel suite
covering empty/undefined/unrecognised/partial supported lists
- codex-sdk-service.test.ts: adds 3 new tests asserting that
sendMessage({ reasoningEffort: 'xhigh' }) passes reasoningLevel: 'xhigh'
to startThread, that omitting reasoningEffort omits reasoningLevel, and
that all four valid effort values (low/medium/high/xhigh) are forwarded
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…h/minimal filtering - Add AC-01 test: GET /api/agent-providers/codex/models returns gpt-5.5 with supportedReasoningEfforts: ['low','medium','high','xhigh'] and defaultReasoningEffort: 'medium' when the Codex SDK service provides it - Add test: listModels throw falls back to empty models (graceful degradation) - Add AC-02 test: useProviderModels preserves xhigh end-to-end from codex catalog via supportedReasoningEfforts / capabilities.supports.reasoning_effort - Add AC-02b test: 'minimal' effort is deliberately filtered; documented reason: the CoC effort picker only supports ['low','medium','high','xhigh'] and has no UI label or end-to-end handling for 'minimal' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add two tests completing AC coverage for 'Queued, buffered, and drained follow-ups preserve xhigh': - queue-executor-bridge-executor-dispatch: passes 'xhigh' per-turn reasoningEffort through CLITaskExecutor → FollowUpExecutor dispatch (the 10th argument of executeFollowUp must be 'xhigh' not undefined) - queue-executor-bridge-reasoning-effort: executeFollowUp() preserves 'xhigh' override end-to-end for a codex-gpt-5.5 process Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- chat-base-executor: resolve reasoningEffort from cfg.models.providers[provider].reasoningEfforts; fall back to global cfg.models.reasoningEfforts only for Copilot (legacy) - follow-up-executor: same provider-scoped lookup using sessionProvider (process.metadata.provider, default 'copilot') - EffortPillSelector: xhigh support, buildEffortOptionsForModel(), disabled/disabledTitle props wired throughout - NewChatArea: derive effortOptions from model; disabled picker when model.capabilities.supports.reasoningEffort === false - FollowUpInputArea: effortDisabled prop; passes to EffortPillSelector - ChatDetail: compute effortPickerDisabled from sessionModelInfo; pass to both FollowUpInputArea instances - useDraftStore/useSendMessage: xhigh support - codex-sdk-service: forward reasoningLevel to Codex SDK - Tests (15 total in queue-executor-bridge-reasoning-effort.test.ts): provider-scoped Auto resolution for Codex (new/follow-up), Copilot legacy fallback (new/follow-up), Codex isolation from global reasoningEfforts map Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Default hides done items from the hierarchy board (done items are now filtered server-side unless includeDone=true is passed) - Added a ✓ toggle button next to the archive toggle in the search bar; active state uses the same blue highlight style as the archive toggle - Extended WorkItemTreeFilter with includeDone?: boolean (coc-client) - filterWithAncestors now filters out status='done' entries when includeDone is false, consistent with the includeArchived pattern - Added 4 new tests: default exclusion, explicit inclusion, mixed statuses, and done-parent-with-active-children behaviour Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.