Fix Inf coordinate values causing shapes not to render #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON doesn't support Inf values - they become null, causing geoms like geom_rect, geom_polygon, geom_line, geom_ribbon, and geom_segment to not render when users specify Inf/-Inf coordinates (a common pattern for "extend to edge" annotations). This fix adds centralized Inf replacement in the ggplot2-to-plotly conversion pipeline, replacing Inf values with the corresponding panel limits after to_basic() returns. This handles all geoms generically without requiring individual fixes. Includes tests for geom_line, geom_rect, geom_polygon, and faceted plots to verify both that Inf values are replaced and that the replacement values match the expected panel limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2364 - JSON doesn't support Inf values, causing geoms to not render when users specify Inf/-Inf coordinates (a common pattern for "extend to edge" annotations).
Changes
replace_inf_in_data()function inR/utils.Rthat replaces Inf values with panel limitsto_basic()returns inR/layers2traces.R, handling all geoms generically (geom_line, geom_rect, geom_polygon, geom_ribbon, geom_segment, etc.)Test plan