Added more registers and support for total energy generated#1
Open
ToeTag wants to merge 3 commits intoplopp:masterfrom
Open
Added more registers and support for total energy generated#1ToeTag wants to merge 3 commits intoplopp:masterfrom
ToeTag wants to merge 3 commits intoplopp:masterfrom
Conversation
plopp
requested changes
Apr 25, 2021
Owner
plopp
left a comment
plopp
left a comment
There was a problem hiding this comment.
Thanks for your submission! Please see my comments.
| #Support functions | ||
|
|
||
| def convertToFloat(input_int): | ||
| #read_long returns a 32-bit int, convert to float... |
Owner
There was a problem hiding this comment.
This does not seem to be correct. From the datasheet the integer returned should be divided by 100 to get the floating point value.
Owner
There was a problem hiding this comment.
| BAT_SOC = 0x311A | ||
| BAT_RATED_VOLTAGE = 0x9067 | ||
|
|
||
| BAT_VOLTAGE_MAX_DAY = 0x3302# 00: 00 Refresh every day V 100 |
Owner
There was a problem hiding this comment.
This seems to be some copy/paste garbage? Please remove.
| print("Batt. temp:\t" + str(temperature) + "C") | ||
|
|
||
| gen_energy_day=instrument.read_long( | ||
| GEN_ENERGY_TODAY_L, 4, False, 0) # Registernumber, number of decimals |
Owner
|
@ToeTag If you need anything, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.