Fix tests for not queries in Products.ZCatalog 7.2.0+.
#171
Conversation
See for example this [failure on Jenkins](https://jenkins.plone.org/job/pull-request-6.2-3.13/426/testReport/junit/plone.app.querystring.tests.testQueryBuilder/TestQuerybuilder/testMakeQueryWithMultipleSubjectNot/). The test created two content items with Subjects, and querying for all items without a specific Subject. This used to return 1 item. But now it returns 2, because the Plone Site object is also returned, which has no Subject set. This object used to be ignored in the catalog. See zopefoundation/Products.ZCatalog#148 What is a bit strange, is that the 'not' query does not return any results when I run it at the beginning of this test, so before any item with this Subject has been set. That might be a problem in ZCatalog still.
|
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
The coredev PR is green. I have pushed |
See for example this failure on Jenkins. The test created two content items with Subjects, and querying for all items without a specific Subject. This used to return 1 item. But now it returns 2, because the Plone Site object is also returned, which has no Subject set. This object used to be ignored in the catalog. See zopefoundation/Products.ZCatalog#148
What is a bit strange, is that the 'not' query does not return any results when I run it at the beginning of this test, so before any item with this Subject has been set. That might be a problem in ZCatalog still.
Note that the GitHub Actions tests will fail because they use an older Products.ZCatalog. So I am making a PR in
buildout.coredevto update the pin and make a checkouts of this PR branch. If that is green, I can merge this PR, and update the ZCatalog pin in the coredev buildout and dist.plone.org.