-
Notifications
You must be signed in to change notification settings - Fork 0
[XELP] properly update brighterscript-formatter #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
865b4be to
fdb9bc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the brighterscript-formatter dependency from version 1.7.2025112720 to 1.7.2025112820 and adds new configuration options for more granular control over keyword and type casing in the BrightScript formatter. The update also includes a correction to an existing description that clarifies an example from "lower case" to "title case" to match the actual behavior.
- Updates the
brighterscript-formatterdependency version and changes the URL format fromhttps://github.com/togithub:shorthand - Adds two new configuration options:
specificKeywordCaseOverrideandspecificTypeCaseOverridefor fine-grained casing control - Clarifies the
keywordCaseOverridedescription to correctly state "title case" instead of "lower case"
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| package.json | Updates brighterscript-formatter dependency URL format and version; adds two new formatter configuration options for specific keyword and type casing overrides; fixes description for keywordCaseOverride example |
| package-lock.json | Updates the resolved version and commit hash for brighterscript-formatter dependency to match the new version |
Comments suppressed due to low confidence (1)
package.json:61
- [nitpick] Inconsistent dependency URL format. The
brighterscript-formatterdependency now usesgithub:plexinc/brighterscript-formatter#...format while thebrighterscriptdependency on line 60 useshttps://github.com/plexinc/brighterscript.git#...format. Consider using the same format for both dependencies for consistency.
"brighterscript-formatter": "https://github.com/plexinc/brighterscript-formatter.git#1.7.2025112820",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
78a96cc to
46310a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.