Ignore multi unbalanced open/close pairs on the same line. #3
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents the MultiLineItemFormatter from reformatting lines that contain multiple types of unbalanced opening brackets/braces on the same line (e.g., [m, { where both [ and { remain open).
Key changes:
- Added
isMultiUnbalancedOpenClosePairmethod to detect when both square brackets and curly braces have unbalanced opening counts on a single line - Integrated this check into the formatting condition chain to skip reformatting in such cases
- Added explicit
return falsestatement at the end ofisMatchingDoubleArrayOrArrayCurlymethod
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/formatters/MultiLineItemFormatter.ts | Added new method isMultiUnbalancedOpenClosePair to detect multiple unbalanced bracket/brace pairs on same line, integrated it into the formatting condition, and added explicit return statement to isMatchingDoubleArrayOrArrayCurly |
| src/formatters/MultiLineItemFormatter.spec.ts | Added test cases for the new functionality and pre-existing isMatchingDoubleArrayOrArrayCurly behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ljunkie
force-pushed
the
rob/style-format-multi-unbalanced
branch
from
95dddbb to
90f97ed
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.