Skip to content

Add filesystem for Screenshots and PDF#84

Draft
stloyd wants to merge 5 commits intoplaywright-php:mainfrom
stloyd:feature/fs-73
Draft

Add filesystem for Screenshots and PDF#84
stloyd wants to merge 5 commits intoplaywright-php:mainfrom
stloyd:feature/fs-73

Conversation

@stloyd
Copy link
Collaborator

@stloyd stloyd commented Mar 7, 2026

No description provided.

@stloyd stloyd requested a review from smnandre March 7, 2026 11:40
use League\Flysystem\UnableToWriteFile;
use Playwright\Exception\RuntimeException;

final readonly class FlysystemFilesystem implements FilesystemInterface
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the final, it can be removed, it's more to showcase the idea.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 7.00000% with 93 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Media/Pdf/Pdf.php 0.00% 43 Missing ⚠️
src/Media/Screenshot/Screenshot.php 0.00% 29 Missing ⚠️
src/Media/Filesystem/LocalFilesystem.php 0.00% 13 Missing ⚠️
src/Media/Filesystem/FlysystemFilesystem.php 0.00% 7 Missing ⚠️
src/Page/Page.php 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant