-
Notifications
You must be signed in to change notification settings - Fork 0
Correct auto tag functionality #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
playmiel
wants to merge
2
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,3 @@ | |
| .vscode/extensions.json | ||
| .github/copilot-instructions.md | ||
| AGENTS.md | ||
| CHANGELOG.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this project are documented in this file. | ||
|
|
||
| ## [Unreleased] | ||
| - (TBD) | ||
|
|
||
| ## [2.1.2] - 2026-03-17 | ||
| - Version bump and release metadata synchronization. | ||
|
|
||
| ## [2.1.0] - 2026-02-26 | ||
| - **Fix**: Use-after-free of `RequestContext` — transport callbacks now capture `shared_ptr<RequestContext>` instead of raw `void*` pointer, preventing dangling access after `cleanup()`. | ||
| - **Fix**: `handleData()` now checks `cancelled` flag at entry, matching `handleDisconnect`/`handleTransportError`. | ||
| - **Fix**: Race condition between `loop()` timeouts and AsyncTCP callbacks — `triggerError()` and `loop()` now check `atomic<bool> cancelled` before acting. | ||
| - **Fix**: `Content-Length` parsing uses `strtoul()` with `endptr` validation instead of `toInt()` (which returns 0 for invalid input). | ||
| - **Fix**: `Transfer-Encoding` multi-value support — `gzip, chunked` is now correctly detected via substring search instead of exact comparison. | ||
| - **Fix**: `setMaxBodySize()` is now enforced in streaming mode (`setNoStoreBody(true)`) to protect against unbounded data from malicious servers. | ||
| - **Perf**: Chunked transfer decoding eliminates double buffering — chunk body bytes are delivered directly from the incoming data buffer instead of being copied through `responseBuffer`. | ||
| - **Perf**: `_pendingQueue` changed from `std::vector` to `std::deque` for O(1) dequeue instead of O(n). | ||
| - **Feature**: `Content-Type` auto-detection for POST/PUT/PATCH — bodies starting with `{` or `[` default to `application/json`; user-set `Content-Type` headers take precedence. | ||
| - Internal: `_activeRequests` now uses `shared_ptr<RequestContext>` instead of `unique_ptr`. | ||
|
|
||
| ## [2.0.0] - 2026-02-20 | ||
| - **Breaking**: `SuccessCallback` now receives `std::shared_ptr<AsyncHttpResponse>`. | ||
| - **Breaking**: `request()` now takes `std::unique_ptr<AsyncHttpRequest>`. | ||
| - **Breaking**: `getBody()`, `getHeader()`, and `getStatusText()` return `String` by value. | ||
| - **Breaking**: removed legacy void-return helpers (`*_legacy`, `ASYNC_HTTP_LEGACY_VOID_API`). | ||
| - **Breaking**: `parseChunkSizeLine()` is now private. | ||
| - Normalize `HttpHeader` names to lowercase for faster lookups. | ||
| - Refactor request context state into sub-structs and store active/pending requests as `std::unique_ptr`. | ||
| - Document `BodyChunkCallback` lifetime guarantees. | ||
| - HTTPS/TLS transport: AsyncTCP + mbedTLS, CA/fingerprint/mutual-auth configuration, TLS error codes, and gated insecure TLS. | ||
| - Redirects: default safer cross-origin header forwarding, allow HTTP→HTTPS redirects. | ||
| - Cookies: host-only by default, allowlist required for parent-domain `Domain=` attributes. | ||
|
|
||
| ## [1.0.7] - 2025-11-13 | ||
| - Align `library.json`, `library.properties`, and `ESP_ASYNC_WEB_CLIENT_VERSION` with release 1.0.7 so CI/release scripts pass. | ||
| - Document contributor expectations in `AGENTS.md` and reconfirm README error codes plus HTTPS warning stay in sync with `HttpCommon.h`. | ||
| - Verified required Arduino/PlatformIO example skeletons for CI (SimpleGet, PostWithData, MultipleRequests, CustomHeaders, StreamingUpload, CompileTest) remain present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title ("Correct auto tag functionality") doesn’t match the actual changes here (version/metadata bump + formatting). This makes the intent of the release harder to track in history and automation; please align the title and/or PR description to reflect the version sync + changelog addition (or add the missing functional changes if they were intended).