Skip to content

Update ratelimit env defaults & remove fallbacks #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fennifith merged 1 commit into from
Jan 20, 2026
Merged

Update ratelimit env defaults & remove fallbacks #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ POSTGRES_URL="postgresql://postgres:unicorn@localhost:5432/postgres"
REDIS_URL="redis://localhost:6379"

HOOF_AUTH_TOKEN=supersecret
RATE_LIMIT_MAX=100
RATE_LIMIT_WINDOW="1 minute"
RATE_LIMIT_MAX=10000
RATE_LIMIT_WINDOW="10 minutes"
RATE_LIMIT_BAN_THRESHOLD=10
6 changes: 3 additions & 3 deletions apps/api/src/plugins/rate-limit/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ export const shouldBypassRateLimit = (
export default fp(
(fastify) => {
fastify.register(rateLimit, {
max: Number(env.RATE_LIMIT_MAX) || 10_000,
timeWindow: env.RATE_LIMIT_WINDOW || "10 minutes",
ban: Number(env.RATE_LIMIT_BAN_THRESHOLD) || 10,
max: env.RATE_LIMIT_MAX,
timeWindow: env.RATE_LIMIT_WINDOW,
ban: env.RATE_LIMIT_BAN_THRESHOLD,
allowList: (request, _key) =>
shouldBypassRateLimit(request, env.HOOF_AUTH_TOKEN),
});
Expand Down
6 changes: 3 additions & 3 deletions packages/common/src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ export const EnvSchema = Type.Object({
REDIS_PASSWORD: Type.Optional(Type.String()),

// Rate limiting configuration
RATE_LIMIT_MAX: Type.Optional(Type.Integer({ default: 100 })),
RATE_LIMIT_WINDOW: Type.Optional(Type.String({ default: "1 minute" })),
RATE_LIMIT_BAN_THRESHOLD: Type.Optional(Type.Integer({ default: 10 })),
RATE_LIMIT_MAX: Type.Integer({ default: 10_000 }),
RATE_LIMIT_WINDOW: Type.String({ default: "10 minutes" }),
RATE_LIMIT_BAN_THRESHOLD: Type.Integer({ default: 10 }),
HOOF_AUTH_TOKEN: Type.Optional(Type.String()),

GITHUB_REPO_OWNER: Type.String({ default: "playfulprogramming" }),
Expand Down