-
-
Notifications
You must be signed in to change notification settings - Fork 3
Sync post #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
20jasper
reviewed
Jan 18, 2026
fennifith
reviewed
Jan 18, 2026
Member
fennifith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Left a few comments :)
To answer your questions:
- Yes, images will need to be handled! That's a good callout.
- Rewriting the URLs in markdown on the server seems brittle, as the image handling is closely tied to the frontend
- It might be better to broadly define "post attachments" as any file adjacent to the post (there are some examples of pdf/pptx files in the repo - and this would also be useful for #29) and sync those with S3
- I don't think that should go in this PR - I've started detailing #86 for this :)
- The
collectionfield definitely isn't needed in the frontmatter, but it is still used by the frontend (it just gets populated elsewhere).
# Conflicts: # apps/worker/test-utils/setup.ts
fennifith
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Happy to bring the first PR here 💪
This built on top of @crutchcorn's #74 mostly following conventions set there. Not a lot of dependencies, though.
Summary
createBucket → ensureBucketfor a better clarity; can be easily reverted cd88eb7Open questions
collectionfiled in PostInfo? Looks redundant now.