[#2173] Add LocalDateTime binder #1236
Conversation
|
@sant0s Thank you for the PR! |
|
@asolntsev You're welcome. Any chance (Lighthouse) tickets 2170 to 2172 could be resolved? |
|
@sant0s Sure they can be resolved. Feel free to prepare a pull requests for them! |
|
@asolntsev That would be great as these issues refer to rather important functionality that was working in previous Play versions but has unfortunately been broken along the way. I had to comment application code as a workaround to make things work in the meantime. Perhaps other developers had to do the same. Issues 2170 and 2171 refer to no longer being possible to access action context items from error templates. The corresponding pull requests are #1230 and #1231. Issue 2172 refers to functional tests returning HTTP 200 instead of HTTP 404 for not found resources, thus violating REST compliance. I've created pull request #1234 but unfortunately it failed in Travis CI, so I've closed it. Do you think you - or someone from the Play team - could fix this issue? |
|
@sant0s @asolntsev I'm fairly certain issue 2172 is actually linked to issue 1849 which we've now fixed in this pr: #1246 |
|
@Fraserhardy @asolntsev I also find it critical, as it inhibits testing, therefore reducing coverage. |
|
@sant0s @Fraserhardy I added my comment to PRs #1230, #1231 and #1246. Thank you for your commitment! |
@asolntsev #1231 didn't go through although #1230 did (in Play! 1.5.2.). Could #1231 be included in the next Play! release? |
4 participants
No description provided.