Exposed the color band width parameter for radial reveal effect #8414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Jan 28, 2026
mvaligursky
commented
- replaced hardcoded number by attribute / uniform
mvaligursky
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes the color band width parameter for the radial reveal effect, allowing developers to customize the width of the color bands for dot and lift waves. Previously, these widths were hardcoded values (1.0 for dot wave, 1.5 for lift wave leading edge, 0.5 for lift wave trailing edge).
Changes:
- Added
uBandWidthuniform to both GLSL and WGSL shader implementations - Replaced all hardcoded band width values with expressions using the new uniform
- Added
bandWidthattribute to theGsplatRevealRadialclass with a default value of 1.0 for backward compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LeXXik
reviewed
Jan 28, 2026
willeastcott
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.