Open
Conversation
With the switch to the /query endpoint, the aggregate query with a page filter started returning `time_on_page` as `nil` without any engagement data, instead of 0 as before. When this happens, Time on Page is simply hidden in Top Stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Could have been done sooner (with the actual endpoint switch) but I mistakenly thought it's needed for Dashboard CSV export. Which it's not.
The
top_stats_test.exsprobably gives the query API v2 a good amount of extra coverage. This PR modernizes that file to keep that coverage:graph_metrickey were removedwith_imported_switch_info, we now assert onquery.skip_imports_reasonandquery.imports_includedin all the same scenarios.Rewriting the tests uncovered two issues:
nil(instead of 0 as before) when it cannot be calculated. For users it means that Top Stats will simply hide the metric. I've updated the test to assert onnil.Tests
Changelog
Documentation
Dark mode