Limit ClickhouseRepo queries max_execution_time #6018
+36
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zoldar
approved these changes
Jan 23, 2026
| readonly: 1, | ||
| join_algorithm: "direct,parallel_hash,hash", | ||
| cancel_http_readonly_queries_on_client_close: 1 | ||
| # stops queries when :timeout option from above reached |
Contributor
There was a problem hiding this comment.
Suggested change
| # stops queries when :timeout option from above reached | |
| # stops queries when :timeout option from below reached |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Limits
ClickhouseRepoqueriesmax_execution_time(a https://clickhouse.com/docs/operations/settings/query-complexity) in casecancel_http_readonly_queries_on_client_closedoesn't take effect.Had to refactor the cases where the repo is used with infinite timeout (exports job, a cleaning job).
Tried to unset
max_execution_timein per-query settings (https://clickhouse.com/docs/operations/settings/query-level#order-of-priority), but those don't work when read-only is set (CH server does not allow it).Tests
Changelog
Documentation
Dark mode