[POC]: A full live dashboard #5993
Draft
+1,251
−2,115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJoonas
force-pushed
the
liveview-dashboard
branch
from
e66c186 to
e240554
Compare
* do not render tile inner block when socket not connected * datepicker hook with optimistic updates * add debounce * fix current day/month/year links * format & credo * fix/remove tests to make CI green
* Add loading skeleton upon page reload * Add loading states for transition between tabs and timeframes * fix compile warnings * fix flicker by adding ids * format and fix tests * Remove unused code from React dashboard * Fix JS and CSS formatting --------- Co-authored-by: Robert Joonas <robertjoonas16@gmail.com> Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
- When switching away from a report that has no data, show a loading skeleton
* do not render tile inner block when socket not connected * datepicker hook with optimistic updates * add debounce * fix current day/month/year links * format & credo * fix/remove tests to make CI green
* Add loading skeleton upon page reload * Add loading states for transition between tabs and timeframes * fix compile warnings * fix flicker by adding ids * format and fix tests * Remove unused code from React dashboard * Fix JS and CSS formatting --------- Co-authored-by: Robert Joonas <robertjoonas16@gmail.com> Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
* Fix link lookup and remove react scaffolding from DashboardRoot * Implement rough version of dashboard-friendly Prima modal wrapper * Implement rough pages details modal * Add rough versions of detail modals for all tabs so far * Use portal for details modals again * Adjust dashboard loading states for full LV * Bump prima to a version with auto_close option * Pass missing attributes to `ReportList` instances after rebase * Improve modal opening and hiding and manage loading state better * Drop unused `class` attribute from `modal` usage instance * Make details modal logic DRY * Add some spacing to make modal contents less cramped * Avoid excessive computation and patches on path change * Fix breakdown modal width - Prima.Modal's modal_panel creates a wrapper div that doesn't receive the class attribute, so width constraints applied directly to modal_panel only affect the inner focus_wrap. Wrapping modal_panel in a div with width classes ensures the constraint applies to the modal's wrapper div. --------- Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
zoldar
force-pushed
the
liveview-dashboard
branch
from
c36553d to
8b9eade
Compare
|
When switching away from a report that has no data, show a loading skeleton
* fix datepicker bug * realtime timer * set realtime refresh interval to 30s * prefer Process over :timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe the changes made in the pull request here.
Below you'll find a checklist. For each item on the list, check one option and delete the other.
Tests
Changelog
Documentation
Dark mode