Refine shared-webapp components and add UI utilities#893
Merged
Conversation
…o date formatters
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary & Motivation
A bundle of small, independent shared-webapp improvements consumed by
accountand back-office surfaces.New shared components:
LinkCard— stylized card with link affordance, used on the account index page.Chart— wrapsrechartsprimitives with a consistent focus ring and accessibility-layer defaults. Directrechartsimports are now lint-blocked via.oxlintrc.jsonand the frontend rules.Badge— adds awarningvariant and ties it into theTenantLogoinitials fallback.Component fixes:
Tablestyling consolidated into the shared component (bg-background, rounded corners,<TableHeader>row styling), so consumers no longer need to re-apply utilities. Back-office tenant overview side-pane sizing tweaked alongside.MultiSelectpopover can now expand beyond the anchor width so long labels render without clipping.useSmartDatealways renders a 4-digit year and exposesomitYear/omitCurrentYearoptions for callers that need a shorter display.Sidebaroverlay breakpoint raised fromlgtoxl; layout heights now offset by the banner so content isn't clipped behind it.New utilities:
shared-webapp/ui/utils/countryFlag.ts.account/BackOffice/shared/lib/api/labels.ts.CI:
npm run lintstep inmain.ymlandaccount.ymlwithdotnet run --project developer-cli -- lint --frontend. The dev-CLI lint runsnpm run lintinternally and adds the missing-translation check, so it both lints and gates.pocompleteness in CI. Drops the now-redundant per-WebAppRun Back Office Lintstep.npm run format+git diff --exit-codesteps with a singledotnet run --project developer-cli -- format --frontend+ diff check, since the dev-CLI format runs across all workspaces in one go.application/shared-webapp/ui/translations/locale/da-DK.po("Loading", "Open calendar") that were exposed once the dev-CLI lint started running.Checklist