Skip to content

Refine shared-webapp components and add UI utilities#893

Merged
tjementum merged 11 commits intomainfrom
pp-1216-refine-shared-webapp-components-and-add-ui-utilities
May 9, 2026
Merged

Refine shared-webapp components and add UI utilities#893
tjementum merged 11 commits intomainfrom
pp-1216-refine-shared-webapp-components-and-add-ui-utilities

Conversation

@tjementum
Copy link
Copy Markdown
Member

@tjementum tjementum commented May 9, 2026

Summary & Motivation

A bundle of small, independent shared-webapp improvements consumed by account and back-office surfaces.

New shared components:

  • LinkCard — stylized card with link affordance, used on the account index page.
  • Chart — wraps recharts primitives with a consistent focus ring and accessibility-layer defaults. Direct recharts imports are now lint-blocked via .oxlintrc.json and the frontend rules.
  • Badge — adds a warning variant and ties it into the TenantLogo initials fallback.

Component fixes:

  • Table styling consolidated into the shared component (bg-background, rounded corners, <TableHeader> row styling), so consumers no longer need to re-apply utilities. Back-office tenant overview side-pane sizing tweaked alongside.
  • MultiSelect popover can now expand beyond the anchor width so long labels render without clipping.
  • useSmartDate always renders a 4-digit year and exposes omitYear / omitCurrentYear options for callers that need a shorter display.
  • Sidebar overlay breakpoint raised from lg to xl; layout heights now offset by the banner so content isn't clipped behind it.

New utilities:

  • Country flag emoji helper in shared-webapp/ui/utils/countryFlag.ts.
  • Label helpers in account/BackOffice/shared/lib/api/labels.ts.

CI:

  • Replace the npm run lint step in main.yml and account.yml with dotnet run --project developer-cli -- lint --frontend. The dev-CLI lint runs npm run lint internally and adds the missing-translation check, so it both lints and gates .po completeness in CI. Drops the now-redundant per-WebApp Run Back Office Lint step.
  • Replace the per-WebApp npm run format + git diff --exit-code steps with a single dotnet run --project developer-cli -- format --frontend + diff check, since the dev-CLI format runs across all workspaces in one go.
  • Fill in 2 missing Danish translations in application/shared-webapp/ui/translations/locale/da-DK.po ("Loading", "Open calendar") that were exposed once the dev-CLI lint started running.

Checklist

  • I have added tests, or done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum requested a review from a team as a code owner May 9, 2026 22:57
@tjementum tjementum added the Enhancement New feature or request label May 9, 2026
@tjementum tjementum self-assigned this May 9, 2026
@linear
Copy link
Copy Markdown

linear Bot commented May 9, 2026

PP-1216

@tjementum tjementum moved this to 🏗 In Progress in Kanban board May 9, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@tjementum tjementum merged commit 9082c10 into main May 9, 2026
29 checks passed
@tjementum tjementum deleted the pp-1216-refine-shared-webapp-components-and-add-ui-utilities branch May 9, 2026 23:10
@github-project-automation github-project-automation Bot moved this from 🏗 In Progress to ✅ Done in Kanban board May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant