Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary & Motivation
Bring the developer CLI under CI and close two gaps in the existing frontend pipeline.
.github/workflows/developer-cli.ymlthat runs build, format, and lint on the developer CLI whenever files underdeveloper-cli/**change. Mirrors the backend pattern frommain.ymland skips the CLI's self-rebuild path withDEVELOPERCLI_SKIP_CHANGE_DETECTION=1. Make it a required check onmainto gate merges.main.ymlandaccount.yml(runnpm run formatthengit diff --exit-code). The backend already had this; the frontend only ran lint, sooxfmt/oxlint --fixdrift could land silently.translatedeveloper-CLI command with a missing-translation check insidelint --frontend. The check parses every non-en-US.pofile (excludingnode_modules) withKarambolo.POand fails with a per-file count when entries have emptymsgstr. Drops thetranslatecommand and its OpenAI/Azure dependency closure (Azure.AI.OpenAI, Microsoft.Extensions.AI{,.OpenAI}, OpenAI).Karambolo.POis kept for the new check;SecretHelperis kept since downstream projects may use it.account/WebAppandaccount/BackOfficeso the new check passes on this branch.main.yml/account.yml. SonarCloud's static analysis stays; coverage is not enforced on PRs. Re-introducing coverage onmain(full-backend, no TypeScript) is tracked separately.README.mdsince coverage is no longer produced on every PR.forcePrompt:named argument inInstallCommand.GitHooksSync.Sync(true)so JetBrains cleanup doesn't rewrite it under the new format gate.Checklist