Simplify infrastructure deployment with Bicep parameters and rename global resource group

[tjementum]

Summary & Motivation

Replace inline Bicep parameter strings with structured .bicepparam files to simplify deployment scripts and improve maintainability. This eliminates manual parameter string construction and makes parameter management cleaner.

• Add main-cluster.bicepparam file that reads all parameters from environment variables
• Update deploy-cluster.sh to use bicep build-params command
• Export all variables instead of constructing inline parameter strings
• Rename global resource group from pxp-stage to pxp-stage-global to clarify these are globally shared resources
• Rename all resource group variables to explicitly distinguish CLUSTER_RESOURCE_GROUP_NAME vs GLOBAL_RESOURCE_GROUP_NAME
• Generate revision suffix in shell script using random hex to avoid Bicep newGuid() what-if validation limitations
• Upgrade all Bicep modules to latest stable API versions
• Remove unsupported softDeletePolicy from Container Registry
• Suppress false positive BCP318 warnings in role assignment modules
• Display DNS configuration instructions during Plan phase
• Fix spelling errors in appGateway module name and issue templates
• Fix bug from previous change where database migration comments were deleted across different self-contained systems

Downstream projects

1. Create new global resource group and move resources

   The global resource group has been renamed from {uniquePrefix}-{environment} to {uniquePrefix}-{environment}-global (e.g., ppdemo-stage → ppdemo-stage-global) for better clarity. Resources keep their original names (e.g., ppdemo-stage).

   • Create the new resource group {uniquePrefix}-{environment}-global in Azure Portal
   • Move these 5 resources using "Move to another resource group":
     • Azure Container Registry (e.g., ppdemostage)
     • Application Insights (e.g., ppdemo-stage)
     • Log Analytics workspace (e.g., ppdemo-stage)
     • Application Insights Smart Detection (action group)
     • Smart detector alert rule (e.g., ppdemo-stage-failure-anomalies)

2. Update self-contained system version exports

   In cloud-infrastructure/cluster/deploy-cluster.sh, update the resource group variable name in your self-contained system version export (all downstream projects have at least one self-contained system beyond Account Management and Back Office):

   -export YOUR_SELF_CONTAINED_SYSTEM_VERSION=$(get_active_version "your-self-contained-system-api" $RESOURCE_GROUP_NAME)
   +export YOUR_SELF_CONTAINED_SYSTEM_VERSION=$(get_active_version "your-self-contained-system-api" $CLUSTER_RESOURCE_GROUP_NAME)

3. Add revisionSuffix parameter to container app modules

   In cloud-infrastructure/cluster/main-cluster.bicep, add the revisionSuffix parameter to your self-contained system container app modules:

        userAssignedIdentityName: yourSelfContainedSystemIdentityName
        ingress: true
   +    revisionSuffix: revisionSuffix
        environmentVariables: yourSelfContainedSystemEnvironmentVariables

4. (Optional) Migrate custom API keys and secrets to bicepparam

   Only needed if you have custom API keys, client secrets, or service configurations beyond standard PlatformPlatform.

   In cloud-infrastructure/cluster/deploy-cluster.sh, ensure custom secrets are exported:

   +export YOUR_CUSTOM_API_KEY
   +export YOUR_CUSTOM_CLIENT_SECRET

   In cloud-infrastructure/cluster/main-cluster.bicepparam, add entries for custom parameters that were in the inline DEPLOYMENT_PARAMETERS string:

   +param yourCustomApiKey = readEnvironmentVariable('YOUR_CUSTOM_API_KEY')
   +param yourCustomClientSecret = readEnvironmentVariable('YOUR_CUSTOM_CLIENT_SECRET')

Checklist

• I have added tests, or done manual regression tests
• I have updated the documentation, if necessary

[github-actions]

Approve Database Migration back-office database on stage

The following pending migration(s) will be applied to the database when approved:

• Initial (20250217000000_Initial)

Migration Script

IF OBJECT_ID(N'[__EFMigrationsHistory]') IS NULL
BEGIN
    CREATE TABLE [__EFMigrationsHistory] (
        [MigrationId] nvarchar(150) NOT NULL,
        [ProductVersion] nvarchar(32) NOT NULL,
        CONSTRAINT [PK___EFMigrationsHistory] PRIMARY KEY ([MigrationId])
    );
END;
GO

BEGIN TRANSACTION;
IF NOT EXISTS (
    SELECT * FROM [__EFMigrationsHistory]
    WHERE [MigrationId] = N'20250217000000_Initial'
)
BEGIN
    INSERT INTO [__EFMigrationsHistory] ([MigrationId], [ProductVersion])
    VALUES (N'20250217000000_Initial', N'9.0.10');
END;

COMMIT;
GO

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud