Skip to content

Fixed bug in remote optigraph multithreading #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlcole3 merged 1 commit into from
Nov 11, 2025
Merged

Fixed bug in remote optigraph multithreading #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/PlasmoBenders/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "PlasmoBenders"
uuid = "491f1417-53b2-48aa-b9da-44cdd6c031b7"
authors = ["David Cole"]
version = "0.3.0"
version = "0.3.1"

[deps]
Plasmo = "d3f7391f-f14a-50cc-bbe4-76a32d1bad3c"
Expand Down
5 changes: 3 additions & 2 deletions lib/PlasmoBenders/src/solution.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ function _optimize_in_forward_pass_multithread!(optimizer::BendersAlgorithm{Remo
@async begin
next_object = optimizer.solve_order[i]

is_feasible, obj_val, duals, t_solve = _optimize_remote_graph_forward(optimizer, next_object)
is_feasible, obj_val, duals, t_solve = _optimize_remote_graph_forward(optimizer, next_object, i)

optimizer.time_subproblem_solves += t_solve
if !is_feasible
Expand All @@ -131,10 +131,11 @@ function _optimize_in_forward_pass_multithread!(optimizer::BendersAlgorithm{Remo
end
end

function _optimize_remote_graph_forward(optimizer::BendersAlgorithm, next_object::RemoteOptiGraph)
function _optimize_remote_graph_forward(optimizer::BendersAlgorithm, next_object::RemoteOptiGraph, i::Int)
feasibility_cuts = get_feasibility_cuts(optimizer)
regularize = get_regularize(optimizer)
add_slacks = get_add_slacks(optimizer)
is_MIP = get_is_MIP(optimizer)

comp_vars = optimizer.comp_vars[next_object]
var_copy_map = optimizer.var_copy_map[next_object]
Expand Down
24 changes: 24 additions & 0 deletions lib/PlasmoBenders/test/LP_solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,18 @@ function test_graphs()
@test isapprox(BendersAlg.best_upper_bound, 5.5, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[1], max_iters = 20, multicut = true, regularize = false, parallelize_benders = false);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.5, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[2], max_iters = 20, multicut = true, parallelize_benders = true);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.5, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

# RemoteOptiGraphs
gtest = build_remote_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[1], max_iters = 20);
Expand Down Expand Up @@ -215,6 +227,18 @@ function test_graphs()
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.5, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_remote_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[1], max_iters = 20, multicut = true, regularize = false, parallelize_benders = false);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.5, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_remote_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[2], max_iters = 20, multicut = true, parallelize_benders = true);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.5, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)
end

function run_tests()
Expand Down
24 changes: 24 additions & 0 deletions lib/PlasmoBenders/test/MIP_solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,18 @@ module Test_MIP_solves
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.8, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[2], max_iters = 20, multicut = true, regularize = false, parallelize_benders = false, strengthened = true);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.8, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[2], max_iters = 20, multicut = true, parallelize_benders = true, strengthened = true);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.8, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

# RemoteOptiGraph
gtest = build_remote_graph()
Expand Down Expand Up @@ -166,6 +178,18 @@ module Test_MIP_solves
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.8, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_remote_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[2], max_iters = 20, multicut = true, regularize = false, parallelize_benders = false, strengthened = true);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.8, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)

gtest = build_remote_graph()
BendersAlg = BendersAlgorithm(gtest, local_subgraphs(gtest)[2], max_iters = 20, multicut = true, parallelize_benders = true, strengthened = true);
run_algorithm!(BendersAlg)
@test isapprox(BendersAlg.best_upper_bound, 5.8, rtol = 1e-6)
@test isapprox(get_gap(BendersAlg), 0, rtol = 1e-6)
end

function run_tests()
Expand Down
Loading