Please consider the following formatting changes to #14693 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alibuild
force-pushed
the
alibot-cleanup-14693
branch
from
431ba6b to
00b5168
Compare
alibuild
force-pushed
the
alibot-cleanup-14693
branch
from
00b5168 to
0044afa
Compare
alibuild
force-pushed
the
alibot-cleanup-14693
branch
from
0044afa to
7c3e160
Compare
alibuild
force-pushed
the
alibot-cleanup-14693
branch
from
7c3e160 to
c19b01b
Compare
…liceO2Group#14668) * TPC: Apply T/P scaling of VDrift only if T/P change is large enough - suppress error for getting reference T/P in case default VDrift is used * remove info message and print warning only once
) * feat: allow sharing of first cluster in ITS tracking * Implement modifications from AliceO2Group#14432 * Move to bounded_vector --------- Co-authored-by: Maximiliano Puccio <maximiliano.puccio@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> Co-authored-by: Felix Schlepper <fschlepp@aliceml.cern.ch>
* Add ITS fake clusters information to the mcMask * remove redundant check --------- Co-authored-by: Francesco Mazzaschi <fmazzasc@alipap1.cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* Avoid cumbersome retrivial of the lifetime * No need to create a string just to format it.
… which allows a response Sec-WebSocket-Accept in handshake. (AliceO2Group#14687) DPL Websocket: Add overloaded encode_websocket_handshake_reply which allows a response Sec-WebSocket-Accept in handshake.
See the macro O2/Detectors/Base/test/rescaleLUT.C as an example, which writes a rescaled LUT to the <original_name>_rescaled.root file. The rescaling parameters are provided as a set of RescRange structs: radial range + scaling coefficient. It uses a method o2::base::MatLayerCylSet::scaleLayersByR(rmin,rmax, factor, bool scaleX2X0=true, bool scaleRho=true). All LUT layers overlapping with rmin:rmax range will be rescaled. Alternatively, one can use directly the method o2::base::MatLayerCylSet::scaleLayersByID(lrIDmin,lrIDmax, factor, bool scaleX2X0=true, bool scaleRho=true) to scale a set of layers [lrIDmin:lrIDmax].
* Add support for EXTRA_PATCH in root dictionary generation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
o2::base::Propagator got method propagateToR(track, r, bool bzOnly, maxSnp ...) which propagates the track (either TrackPar or TrackParCov) to requested radius (not X!) if it is reachable in any tracking frame. The rotations to avoid track snp goind outside of the allowed range are done automatically. Moved HelixHelper to ReconstructionDataFormats.
…exing for O2Physics
…eO2Group#14698) * Add possibility to apply signal filtering for MC with embedding * Add protection for signal filtering to be enabled only with emdedding
This should reduce big spikes at the end of the processing when a large HistogramRegistry is serialised.
…cs usage (AliceO2Group#14730) * Revert "TOF Param container: move to header only" This reverts commit 1aa2c14. * Add DataFormatsParamTOF library to CMakeLists
…liceO2Group#14747) * GPU TPC: added dynamic buffer allocation during track-model decoding * GPU TPC: improvement for dynamic buffer size for track-model decoding * GPU TPC: increased margins for track-model decoding buffers
…ld be on the stack
an important step for the mc-on-data embedding
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* basic geometry and data format for new detector * fixed geometry and json * fixed hits * updated geometry and detector source code * updated geometry and detector source code * minor fixes * sensitive volumes * geometry update * geometry update * enable hits * enable hits * enable hits * fix channel ids * More flexible confgurable parameters * More flexible confgurable parameters * update parameters and geometry * fixed ring sizes * merge conflict * GPU * fix conflicts * resolve conflicts * head * GPU * added Constants.h to store constants * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * created new namespace * created new namespace * created new namespace * change name of the detector * change name of the detector * check errors * check errors * Flexible ring radii, a new Boolean switch for module A, module coverage in eta independent of their position * correct default number of ring of A side * Modified default parameters * Hits from charged tracks only * Fixed hit merging * return to the previous choice * updated eta min/max definitions * updated eta definitions * remove spurious files * Update CMake * removed GPU file * Add FD detector * including aluminium containers * including aluminium containers * including aluminium containers * including aluminium containers * including aluminium containers * Please consider the following formatting changes * Updated Readme * introduced FD hit data format * introduced FD hit data format * corrected copyright notice * corrected copyright notice * corrected copyright notice * Finding detId from fMC * colors * change detector name * change detector name * change detector name * change detector name * Fix formatting in CMakeLists.txt for FD3Simulation --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This fixes a problem with embedding and when option `--embedIntoFile` is used. Here, we had an index problem in the primary generator class, which was not taking into account the actual event index according the collision context. This could lead to wrong vertices or using wrong MCHeader information for the embedding decision.
This reverts commit 9254832.
…4736) * ALICE3-TRK: adding macro to check digitization output * Fixing build issues
alibuild
force-pushed
the
alibot-cleanup-14693
branch
from
c19b01b to
5396e16
Compare
plariono
force-pushed
the
refactor-iris-geom
branch
from
8a3ddd1 to
fd37c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your PR AliceO2Group#14693 cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.