Skip to content

Conversation

@MrRob100
Copy link

@MrRob100 MrRob100 commented Nov 5, 2024

Added download reviews plugin to plugin list
#318

@MrRob100 MrRob100 requested a review from asmecher November 5, 2024 22:48
@MrRob100
Copy link
Author

@asmecher The changes are in are you able to take a look again?

@asmecher
Copy link
Member

@MrRob100, with apologies for the delay -- it looks like the plugin was packaged without the Composer dependencies included. I'd suggest packaging this with the plugin CLI tool, which takes care of building the .tar.gz with those included: https://docs.pkp.sfu.ca/dev/plugin-guide/en/release

@MrRob100
Copy link
Author

@MrRob100, with apologies for the delay -- it looks like the plugin was packaged without the Composer dependencies included. I'd suggest packaging this with the plugin CLI tool, which takes care of building the .tar.gz with those included: https://docs.pkp.sfu.ca/dev/plugin-guide/en/release

Thanks. That's in now

@asmecher
Copy link
Member

Thanks, @MrRob100! Can you rebase the PR? There's a conflict against main.

@MrRob100
Copy link
Author

Thanks, @MrRob100! Can you rebase the PR? There's a conflict against main.

Can you check again please? It says no conflicts with base branch. It's only commits ahead

@asmecher
Copy link
Member

@MrRob100, it's still not letting me merge:
image

@MrRob100
Copy link
Author

@asmecher I have just rebased now. How does it look for you?

Screenshot 2025-12-12 at 09 16 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants