I12672#2333
Open
jardakotesovec wants to merge 3 commits into
Open
Conversation
jardakotesovec
force-pushed
the
i12672
branch
3 times, most recently
from
6b77b93 to
74d590e
Compare
OMP's submissionFile schema and DAO overrides had drifted from lib/pkp's media-files additions: - schemas/submissionFile.json: the fileStage validation list rejected SUBMISSION_FILE_MEDIA (23), so media files could not be created. - classes/submissionFile/DAO.php: primaryTableColumns lacked variantType/variantGroupId, so media variant data was written to submission_file_settings instead of the submission_files columns. Sync both with lib/pkp so media files can be created and queried in OMP.
Embed publication-level media files (ASSOC_TYPE_PUBLICATION / SUBMISSION_FILE_MEDIA, web variant only) in the HTML monograph file viewer in addition to dependent files, and allow the catalog download endpoint to serve them. Mirrors pkp/ojs#5534 for OMP.
Extract the HTML-content rendering (embeddable-file URL rewriting, omp:// resolution, style injection, placeholder substitution) into a standalone HtmlGalleyHelper so it can be reused by themes that embed the body inline. Mirrors pkp/ojs#5534 for OMP.
ewhanson
approved these changes
May 18, 2026
Contributor
ewhanson
left a comment
ewhanson
left a comment
There was a problem hiding this comment.
Just the one question, but don't think it's a big deal either way.
| return app()->get('file')->download($submissionFile->getData('fileId'), $filename); | ||
| case Application::ASSOC_TYPE_PUBLICATION: // Publication-level media file | ||
| if ( | ||
| $submissionFile->getData('assocId') != $publication->getId() |
Contributor
There was a problem hiding this comment.
I know this isn't the pattern in the rest of the file, but it got me wondering if it would be better to do !=== or is !== necessary because one of them could come back as a string or int?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.