Skip to content

audit for project name != display-name #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mxcl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audit for project name != display-name #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions audit/audit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if (!config.pkg) {

await audit_provides(config.pkg)
await audit_names(config.pkg)
await audit_display_name_is_unique(config.pkg)
await audit_display_name(config.pkg)


//////////////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -79,15 +79,28 @@ function audit_names(pkg: Package) {
}
}

async function audit_display_name_is_unique(pkg: Package) {
const display_name = await get_display_name(pkg.project)
if (!display_name) return
if (!isString(display_name)) fail("display-name is not string")
async function audit_display_name(pkg: Package) {
const display_name = await get_display_name(pkg.project);

for await (const entry of usePantry().ls()) {
if (entry.project == pkg.project) continue
if (await get_display_name(entry.project) == display_name) {
fail(`error: display-name is not unique, (see: ${entry.project})`)
await audit_display_name_is_unique();
await audit_display_name_is_not_project_name();

function audit_display_name_is_not_project_name() {
if (pkg.project == display_name) {
fail(`error: display-name is the same as project name. There’s nothing inherently wrong with this, but it’s redundant and we don’t want it.`);
}
}

async function audit_display_name_is_unique() {

if (!display_name) return
if (!isString(display_name)) fail("display-name is not string")

for await (const entry of usePantry().ls()) {
if (entry.project == pkg.project) continue
if (await get_display_name(entry.project) == display_name) {
fail(`error: display-name is not unique, (see: ${entry.project})`)
}
}
}

Expand Down
Loading