Skip to content

Add warning for extra symbols in single-expression contexts #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhoenixBound wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add warning for extra symbols in single-expression contexts #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,27 @@ Program* Parser::Parse()
Expression* Parser::ParseExpression()
{
getsym();
return expression();
Expression* e = expression();

// Add a warning (error?) for all trailing tokens, because we only wanted to parse
// a single expression
if(sym != finished) {
stringstream ss;
string empty_string{};

while(sym != finished) {
ss << "ignoring unexpected symbol '" << last.ToString() << "' after expression";
Warning(ss.str(), line);

// Reset error text
ss.str(empty_string);

// Advance to the next token
getsym();
}
}

return e;
}


Expand Down Expand Up @@ -514,4 +534,4 @@ Expression* Parser::primaryexpr() {
ss << "symbol '" << last.ToString() << "'";
Error(ss.str(), last.line);
return new ErrorExpr(last.line, "unexpected symbol '" + last.ToString() + "'");
}
}