This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Open
Conversation
Owner
|
@andrewmp1 originally the different between an relationship with a promise and one without was our apps flow for creating new records. In that case we were adding relationships that were not promise aware just referenced in the relationships property (object) of the model. @aars I think you are correct there is a gap between an empty relation and an async one. Maybe all relations should use the proxy to be consistent. An empty relationship could be the promise proxy but resolved with content as |
Collaborator
Author
|
@pixelhandler Going with a proxy for empty objects will also tackle the "cached relationship" issue. Good call. I'll send in a new PR for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is somewhat related to #141.
related proxy's are promise/able, except when they're not. Empty relationships do not support promises, so you can't always go
model.get('some-relationship').then(relationship => { if (relationship) { // we have a relationship })because there is nothenfor empty relationships.Again, no tests for this (except that the current tests don't break). I will eventually add some, but I need to get my actual Ember app going, so I'm currently just collecting bugs and fixes. (if all these PRs and communication is not useful I can stack all these changes/bugs/issues/fixes on my own fork and discuss them later).