Hardening suggestions for codemodder-python / ISS-2708/python-sonar-secure-cookie #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeebot
bot
requested review from
andrecsilva and
clavedeluna
as code owners
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
src/core_codemods/delete_me.py
Outdated
| response = flask.make_response() | ||
| var = "hello" | ||
| response.set_cookie("name", "value") | ||
| response.set_cookie("name", "value", secure=True, httponly=True, samesite='Lax') |
Contributor
Author
There was a problem hiding this comment.
Flask response set_cookie call should be called with secure=True, httponly=True, and samesite='Lax'.
src/core_codemods/delete_me.py
Outdated
| response2 = flask.Response() | ||
| var = "hello" | ||
| response2.set_cookie("name", "value") | ||
| response2.set_cookie("name", "value", secure=True, httponly=True, samesite='Lax') |
Contributor
Author
There was a problem hiding this comment.
Flask response set_cookie call should be called with secure=True, httponly=True, and samesite='Lax'.
pixeebot
bot
force-pushed
the
pixeebot/ISS-2708/python-sonar-secure-cookie
branch
from
ad4a2a1 to
8c67604
Compare
pixeebot
bot
force-pushed
the
pixeebot/ISS-2708/python-sonar-secure-cookie
branch
from
8c67604 to
772c141
Compare
|
1 similar comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (969 - New Codemod: Sonar Flask Secure Cookie) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs