Skip to content

Fix finding IDs for semgrep sarifs #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drdavella merged 1 commit into from
Dec 20, 2024
Merged

Fix finding IDs for semgrep sarifs #960

drdavella merged 1 commit into from
Dec 20, 2024

Conversation

@drdavella
Copy link
Member

@drdavella drdavella commented Dec 20, 2024

  • Use the base SARIF logic for populating finding IDs

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@drdavella drdavella enabled auto-merge December 20, 2024 19:44
@drdavella drdavella added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 8d0af71 Dec 20, 2024
15 checks passed
@drdavella drdavella deleted the fix-semgrep-finding-ids branch December 20, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhafley dhafley dhafley approved these changes

@andrecsilva andrecsilva Awaiting requested review from andrecsilva andrecsilva is a code owner

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drdavella @dhafley