Skip to content

freeze FixResult and child attr classes #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clavedeluna merged 1 commit into from
Jul 22, 2025
Merged

freeze FixResult and child attr classes #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/codemodder/codetf/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,14 @@ class DiffSide(CaseInsensitiveEnum):


class PackageAction(BaseModel):
model_config = ConfigDict(frozen=True)
action: Action
result: PackageResult
package: str


class Change(BaseModel):
model_config = ConfigDict(frozen=True)
lineNumber: int
description: Optional[str]
diffSide: DiffSide = DiffSide.RIGHT
Expand All @@ -87,11 +89,13 @@ def validate_description(self):


class Rating(BaseModel):
model_config = ConfigDict(frozen=True)
score: int
description: Optional[str] = None


class FixQuality(BaseModel):
model_config = ConfigDict(frozen=True)
safetyRating: Rating
effectivenessRating: Rating
cleanlinessRating: Rating
33 changes: 10 additions & 23 deletions src/codemodder/codetf/v3/codetf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
from enum import Enum
from typing import Optional

from pydantic import BaseModel, model_validator
from pydantic import BaseModel, ConfigDict, model_validator

from codemodder.llm import TokenUsage
from codemodder.logging import logger

from ..common import Change, CodeTFWriter, Finding, FixQuality
Expand Down Expand Up @@ -39,6 +38,7 @@ class Run(BaseModel):
class FixStatusType(str, Enum):
"""Status of a fix"""

model_config = ConfigDict(frozen=True)
fixed = "fixed"
skipped = "skipped"
failed = "failed"
Expand All @@ -48,12 +48,15 @@ class FixStatusType(str, Enum):
class FixStatus(BaseModel):
"""Metadata describing fix outcome"""

model_config = ConfigDict(frozen=True)

status: FixStatusType
reason: Optional[str] = None
details: Optional[str] = None


class ChangeSet(BaseModel):
model_config = ConfigDict(frozen=True)
path: str
diff: str
changes: list[Change] = []
Expand All @@ -76,6 +79,7 @@ class Strategy(str, Enum):


class AIMetadata(BaseModel):
model_config = ConfigDict(frozen=True)
provider: Optional[str] = None
models: Optional[list[str]] = None
total_tokens: Optional[int] = None
Expand All @@ -84,12 +88,14 @@ class AIMetadata(BaseModel):


class GenerationMetadata(BaseModel):
model_config = ConfigDict(frozen=True)
strategy: Strategy
ai: Optional[AIMetadata] = None
provisional: bool


class FixMetadata(BaseModel):
model_config = ConfigDict(frozen=True)
# Fix provider ID, corresponds to legacy codemod ID
id: str
# A brief summary of the fix
Expand All @@ -103,6 +109,8 @@ class FixMetadata(BaseModel):
class FixResult(BaseModel):
"""Result corresponding to a single finding"""

model_config = ConfigDict(frozen=True)

finding: Finding
fixStatus: FixStatus
changeSets: list[ChangeSet] = []
Expand All @@ -120,27 +128,6 @@ def validate_fixMetadata(self):
raise ValueError("fixMetadata must be provided for fixed results")
return self

def store_token_data(self, token_usage: TokenUsage):
if token_usage == TokenUsage() or not self.fixMetadata:
return

if not self.fixMetadata.generation.ai:
self.fixMetadata.generation.ai = AIMetadata(
total_tokens=token_usage.total,
completion_tokens=token_usage.completion_tokens,
prompt_tokens=token_usage.prompt_tokens,
)
else:
self.fixMetadata.generation.ai.completion_tokens = (
self.fixMetadata.generation.ai.completion_tokens or 0
) + token_usage.completion_tokens
self.fixMetadata.generation.ai.prompt_tokens = (
self.fixMetadata.generation.ai.prompt_tokens or 0
) + token_usage.prompt_tokens
self.fixMetadata.generation.ai.total_tokens = (
self.fixMetadata.generation.ai.total_tokens or 0
) + token_usage.total


class CodeTF(CodeTFWriter, BaseModel):
run: Run
Expand Down
Loading