Skip to content

Do not filter Sonar results by status #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drdavella merged 1 commit into from
Jun 18, 2025
Merged

Do not filter Sonar results by status #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/core_codemods/sonar/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ def from_json(cls, json_file: str | Path) -> Self:

result_set = cls()
for result in data.get("issues", []) + data.get("hotspots", []):
if result["status"].lower() in ("open", "to_review"):
result_set.add_result(SonarResult.from_result(result))
result_set.add_result(SonarResult.from_result(result))

return result_set
except Exception:
Expand Down
33 changes: 0 additions & 33 deletions tests/test_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,39 +216,6 @@ def test_or(self, tmpdir):
result2["python:S5659"][Path("code.py")][0],
]

def test_sonar_only_open_issues(self, tmpdir):
issues = {
"issues": [
{
"rule": "python:S5659",
"status": "OPEN",
"component": "code.py",
"textRange": {
"startLine": 1,
"endLine": 1,
"startOffset": 1,
"endOffset": 1,
},
},
{
"rule": "python:S5659",
"status": "RESOLVED",
"component": "code.py",
"textRange": {
"startLine": 1,
"endLine": 1,
"startOffset": 1,
"endOffset": 1,
},
},
]
}
sonar_json1 = Path(tmpdir) / "sonar1.json"
sonar_json1.write_text(json.dumps(issues))

result = SonarResultSet.from_json(sonar_json1)
assert len(result["python:S5659"][Path("code.py")]) == 1

def test_sonar_flows(self, tmpdir):
issues = {
"issues": [
Expand Down
Loading