Patched an issue with formatting empty elements #480
Conversation
| * | ||
| * @param xmlDocumentString Rendered POM Document Contents (string-formatted) | ||
| * @return map of (index, matchData object) reverse ordered | ||
| * @return map of (index, matchData object) reve/rse ordered |
| import org.xmlunit.diff.Diff; | ||
| import org.xmlunit.diff.Difference; | ||
|
|
||
| @Execution(ExecutionMode.SAME_THREAD) |
There was a problem hiding this comment.
This seems like a smell - do we need this and why?
There was a problem hiding this comment.
No clue. Without this, the tests are flaky and interfere with each other. Sometimes it works, sometimes don't.
Seemed to work fine before adding the new test. But I did fix a bug with resource location when adding it.
I can do a deeper investigation if you merit it worth it.
There was a problem hiding this comment.
Yes please. I doubt the real use of this is multithreaded but I think at a minimum we need to understand this a little bit better and leave some comments or something.
There was a problem hiding this comment.
The issue was being caused because we were always using the same instance of FormatCommand from a static variable. I was able to reproduce it in the main branch, but only after dozens of runs.
|
2 participants
No description provided.