Skip to content

Conversation

@andrecsilva
Copy link
Contributor

@andrecsilva andrecsilva commented Nov 27, 2024

Removes a section of the code that deals with preserving formatting from self-closing/empty element in POM files.

Also disabled a test that asserts such format preservation.

This is meant to be a temporary change while we aim for a more permanent fix.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pixeebot
Copy link
Contributor

pixeebot bot commented Nov 27, 2024

Triage summary ✨

Sonar found 4 issue(s) and I was able to help with 4 of them. We think 4 are true positives.

  • Remove this unused "lastIndex" local variable.

    Finding ID: AZNtS7DH4NsKH5MsD1Hr 🚩 True Positive
    Suggestion: Change Status to True Positive

    This rule is very accurate, you should follow the recommendations provided by Sonar for this issue.

  • This block of commented-out lines of code should be removed.

    Finding ID: AZNtS7DH4NsKH5MsD1Hs 🚩 True Positive
    Suggestion: Change Status to True Positive

    This rule is very accurate, you should follow the recommendations provided by Sonar for this issue.

    Finding ID: AZNtS7DH4NsKH5MsD1Ht 🚩 True Positive
    Suggestion: Change Status to True Positive

    This rule is very accurate, you should follow the recommendations provided by Sonar for this issue.

    Finding ID: AZNtS7DH4NsKH5MsD1Hu 🚩 True Positive
    Suggestion: Change Status to True Positive

    This rule is very accurate, you should follow the recommendations provided by Sonar for this issue.

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Configure

@andrecsilva andrecsilva marked this pull request as ready for review November 27, 2024 11:16
@andrecsilva andrecsilva requested a review from nahsra November 27, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants