(Sonar) Fixed finding: "Classes should not be loaded dynamically" #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixee-standardchartered[bot]](https://avatars.githubusercontent.com/u/120601610?s=60&v=4){kind=small}
| <sonar.host.url>https://sonarcloud.io</sonar.host.url> | ||
| <sonar.organization>pixee</sonar.organization> | ||
| </properties> | ||
| <versions.java-security-toolkit>1.2.1</versions.java-security-toolkit> |
Author
There was a problem hiding this comment.
This library holds security tools for protecting Java API calls.
License: MIT ✅ | Open source ✅ | More facts
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Author
|
I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it? If this change was not helpful, or you have suggestions for improvements, please let me know! |
Author
|
Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them! |
Author
|
This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know! You can also customize me to make sure I'm working with you in the way you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediation
This change fixes "Classes should not be loaded dynamically" (id = java:S2658) identified by Sonar.
Details
This change fixes Reflection Injection vulnerabilities by limiting what types can be loaded.
Without a protection like this, attackers can cause arbitrary classes to be loaded, methods to be executed, etc., in your application, which could lead to remote code execution, denial of service, or other unwanted behaviors.
Depending on how the reflection APIs are used and what types are available on the classpath, this vulnerability can be quite dangerous, and in fact GitHub itself had a High-severity vulnerability of this type recently .
This change can be improved further by adding more restrictions like this available in the
ReflectionAPI.More reading
I have additional improvements ready for this repo! If you want to see them, leave the comment:
... and I will open a new PR right away!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs | Codemod ID: sonar:java/unsafe-reflection-s2658