Add separate base cost and margin pricing formulas#43
Draft
Conversation
Co-authored-by: Jakub Duras <jakub@duras.me>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baseCostFormulaandmarginFormulaon product pricing, while keeping legacyformulacompatibilitybaseCost,margin, andpriceduring cart-item pricing hydrationWalkthrough
billboards_pricing_updates.mp4
Total after size selection
Total after configuration selection
pricing_breakdown_smoke.log
Testing
npm run lint(passes; 1 pre-existing unrelated warning insrc/app/[locale]/page.tsx)npm run build(passes)npx tsx /tmp/pricing_smoke.ts(passes; validates both dual-formula and legacy formula pricing breakdown)/en/order/item/bb123?productId=eadb7fea-799e-4bf0-a9e2-beb98860165fconfirms total updates as options are changedTo show artifacts inline, enable in settings.