Refine the code structure for percentile rank#13
Merged
pitrou merged 3 commits intopitrou:percentile-rank-kernelfrom Jan 20, 2025
Merged
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
zanmato1984
commented
Jan 17, 2025
pitrou
reviewed
Jan 20, 2025
pitrou
reviewed
Jan 20, 2025
pitrou
approved these changes
Jan 20, 2025
Owner
pitrou
left a comment
There was a problem hiding this comment.
This is neat, thank you. Can you just address the two comments I posted?
Owner
|
Or I can just do so myself, actually. |
Author
|
Thank you. Let me do this right away. |
Author
|
Comments addressed. @pitrou |
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refinement is based on facts that:
NullPartitionResultgenerated by "sort and mark duplicate";Therefore we can decouple these two operations from the current
Ranker, and only combine them in the concreteRankXXXMetaFunctions, which themselves can be CRTP-ed.This refinement: