PR to improve tests by requiring callback fn only for async tests#10
Open
jmaguirrei wants to merge 1 commit intopirple:masterfrom
Open
PR to improve tests by requiring callback fn only for async tests#10jmaguirrei wants to merge 1 commit intopirple:masterfrom
jmaguirrei wants to merge 1 commit intopirple:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 6 - Adding Unit Tests modified to make testing more flexible.
Synchronous tests like:
Does not require callback function (done) anymore.
On the other hand, async tests still works when callback function is passed:
So test runner now is more flexible and reduces boilerplate for sync functions.