Skip to content

Update version for codegen container#6717

Closed
khanhtc1202 wants to merge 2 commits into
masterfrom
update-go-version-for-codegen-container
Closed

Update version for codegen container#6717
khanhtc1202 wants to merge 2 commits into
masterfrom
update-go-version-for-codegen-container

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

What this PR does:

part of updating go version for pipecd to v1.26.2

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner April 27, 2026 08:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.54%. Comparing base (99acf82) to head (e6c7e4a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6717      +/-   ##
==========================================
+ Coverage   27.51%   29.54%   +2.02%     
==========================================
  Files         554      592      +38     
  Lines       59393    63413    +4020     
==========================================
+ Hits        16343    18734    +2391     
- Misses      41792    43231    +1439     
- Partials     1258     1448     +190     
Flag Coverage Δ
. 23.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 32.43% <ø> (ø)
.-pkg-app-pipedv1-plugin-ecs 31.82% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 58.37% <ø> (?)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 61.90% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 37.95% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 33.04% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 52.71% <ø> (ø)
.-pkg-plugin-sdk 50.14% <ø> (-0.20%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202
Copy link
Copy Markdown
Member Author

I found an issue in this rabbit hole :(

  • go version update requires code/gen to be passed
  • code/gen go version update requires lint to be passed
  • lint to be passed relies on list-go-modules step in the lint workflow, which lists all go modules in pipecd repo (no ignore)

Should we temporarily mark the lint/go workflow as not required in order to update go version for modules first, then re-enable it later? cc @Warashi @mohammedfirdouss

@mohammedfirdouss
Copy link
Copy Markdown
Contributor

Should we temporarily mark the lint/go workflow as not required in order to update go version for modules first, then re-enable it later? cc @Warashi @mohammedfirdouss

Yes this is fine @khanhtc1202 as long as we have a single tracking PR that lists all affected modules and re-enabling lint is the last step before closing it.

@khanhtc1202
Copy link
Copy Markdown
Member Author

@Warashi @mohammedfirdouss Temporary removed go-lint-complete as required workflow in order to merge this PR. I will re-enable it later

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) May 7, 2026 14:54
@khanhtc1202
Copy link
Copy Markdown
Member Author

Changed my mind, should make code/gen step as not required instead of this lint+test steps. WIll check the behavior via PR #6711

@khanhtc1202
Copy link
Copy Markdown
Member Author

The PR ##6711 is updated and all passed except the codegen, which is expected behavior. Let's me close this PR and after #6711 being merged, I will update that codegen image and re-enable codegen as required steps for CI check.

auto-merge was automatically disabled May 28, 2026 03:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants