[Multi_K8s-Plugin] Traffic Routing Log Updates#6648
Merged
Warashi merged 2 commits intopipe-cd:masterfrom Apr 5, 2026
Merged
Conversation
…OUTING stage Add per-route log lines to K8S_TRAFFIC_ROUTING so the PipeCD UI shows which VirtualService routes were updated and which were skipped due to editableRoutes filtering. Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
mohammedfirdouss
force-pushed
the
feat/traffic-routing-route-log
branch
from
4f712dd to
890a891
Compare
mohammedfirdouss
changed the title
Contributor
Author
|
With |
Warashi
reviewed
Apr 5, 2026
Member
Warashi
left a comment
Warashi
left a comment
There was a problem hiding this comment.
Nice improvement!
We can improve the same thing in the k8s plugin, so please fix it too?
Contributor
Author
Alright no problem, will do so. |
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Contributor
Author
|
All good with single and multi cluster update @Warashi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Adds per-route log lines to the
K8S_TRAFFIC_ROUTINGstage for Istio traffic routing, in both thekubernetesandkubernetes_multiclusterplugins.When
editableRoutesis configured, each route now logs whether it was updated or skipped:Skipping route "admin-route" (not in editableRoutes)Updated route "primary-route": primary=80%, canary=10%, baseline=10%Why we need it: Previously there was no way to verify
editableRoutesbehaviour from the PipeCD UI — you had to runkubectl get virtualservicemanually to confirm which routes were modified. This makes the stage log the source of truth.Which issue(s) this PR fixes: #6446
Does this PR introduce a user-facing change?:
K8S_TRAFFIC_ROUTINGstage log now shows per-route update/skip messages when using Istio routing.