Open
Conversation
Signed-off-by: theycallmeaabie <theycallmeaabie@gmail.com>
Signed-off-by: theycallmeaabie <theycallmeaabie@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds unit tests around builder.buildApp execution paths and removes an obsolete TODO requesting such coverage.
Changes:
- Added
TestBuildApptable tests covering API failures, missing deploy source, plugin registry failures, plugin behaviors, and a happy path. - Introduced supporting fakes for API client, repo/worktree, secret decrypter, and plugin registry/client.
- Removed the
// TODO: add testscomment abovebuildApp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/app/pipedv1/planpreview/builder_test.go | Adds fakes and a new table-driven test suite to exercise buildApp scenarios. |
| pkg/app/pipedv1/planpreview/builder.go | Removes the TODO comment now that buildApp has tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: theycallmeaabie <theycallmeaabie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds tests for the buildApp function in
pkg/app/pipedv1/planpreview/builder.goand removes theTODOcomment.Why we need it:
There was an existing
TODOasking for test coverage on buildApp. The new tests cover error handling for API failures, missing deploy sources, plugin registry errors, and the happy path with plugin plan preview results.Does this PR introduce a user-facing change?: