Skip to content

Eventwatcher failure notification#6501

Open
Ansita20 wants to merge 3 commits intopipe-cd:masterfrom
Ansita20:eventwatcher-failure-notification
Open

Eventwatcher failure notification#6501
Ansita20 wants to merge 3 commits intopipe-cd:masterfrom
Ansita20:eventwatcher-failure-notification

Conversation

@Ansita20
Copy link

@Ansita20 Ansita20 commented Feb 2, 2026

Summary

This PR fixes missing error reporting when event handling fails by properly notifying the API with EVENT_FAILURE status.

Previously, failures during event handling were not correctly propagated, which limited observability and prevented downstream components from reacting to these failures.

Changes

  • Report event handling failures to the API using EVENT_FAILURE
  • Include clear and descriptive error messages explaining why the event failed
  • Ensure the control-plane and Deployments can react appropriately to failed events

Benefits

  • ✅ Proper error notification: Failures are now correctly reported to the API with EVENT_FAILURE status
  • ✅ Subsequent deployment triggers: The control-plane and Deployments can now react to event handling failures
  • ✅ Better observability: Clear error messages explain why events failed to be handled
  • ✅ No breaking changes: Existing functionality remains intact; only adds missing error reporting

Validation

  • The code has been validated and compiles successfully
  • No existing behavior is changed apart from adding missing failure reporting

Related Issue

Closes #4750

Signed-off-by: ansita20 <ansitasingh20@gmail.com>
@Ansita20 Ansita20 requested a review from a team as a code owner February 2, 2026 18:48
Signed-off-by: ansita20 <ansitasingh20@gmail.com>
@Ansita20 Ansita20 force-pushed the eventwatcher-failure-notification branch from ba9c138 to 3d7ec14 Compare February 2, 2026 18:48
Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Contributing.md should be done in a separate PR. Please change.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Ansita20
Copy link
Author

Ansita20 commented Feb 3, 2026

Changes to Contributing.md should be done in a separate PR. Please change.

Yes sir I wll make the changes.

Signed-off-by: ansita20 <ansitasingh20@gmail.com>
@Ansita20
Copy link
Author

Ansita20 commented Feb 3, 2026

@eeshaanSA
Sir, I have made the required changes. I accidentally merged the file along with the CONTRIBUTE.md changes earlier sorry about that. I’ve now fixed the commit and updated it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notify the FAILURE of handling event by Event Watcher

2 participants