Skip to content

Conversation

@tujii
Copy link

@tujii tujii commented Oct 3, 2024

This PR includes the following changes:

Android: Updated JVM target compatibility to ensure consistent Java and Kotlin compilation.
Set sourceCompatibility and targetCompatibility to Java 17.
Configured kotlinOptions to use JVM target 17.
Updated Kotlin version to 1.9.10.
Version Bump: Updated the package version to 2.1.0 in pubspec.yaml.
This pull request includes several updates to the flutter_native_timezone plugin, focusing on upgrading dependencies and improving compatibility with newer versions of Java and Kotlin.

Dependency and Compatibility Upgrades:

  • android/build.gradle: Upgraded Kotlin version from 1.5.30 to 1.9.10 to ensure compatibility with newer features and improvements.
  • android/build.gradle: Updated compileOptions and kotlinOptions to use Java 17, improving compatibility with the latest Java version.

Version Bump:

  • pubspec.yaml: Increased the plugin version from 2.0.1 to 2.1.0 to reflect the updates and improvements made.

- Updated [`compileOptions`](command:_github.copilot.openSymbolFromReferences?%5B%22%22%2C%5B%7B%22uri%22%3A%7B%22scheme%22%3A%22file%22%2C%22authority%22%3A%22%22%2C%22path%22%3A%22%2FUsers%2Ftujiiprince%2Fdevelop%2Fpackages_fork%2Fflutter_native_timezone%2Fandroid%2Fbuild.gradle%22%2C%22query%22%3A%22%22%2C%22fragment%22%3A%22%22%7D%2C%22pos%22%3A%7B%22line%22%3A29%2C%22character%22%3A4%7D%7D%5D%2C%2259833c6d-ef6f-4aec-8ca5-d1739b0c5a72%22%5D "Go to definition") to set [`sourceCompatibility`](command:_github.copilot.openSymbolFromReferences?%5B%22%22%2C%5B%7B%22uri%22%3A%7B%22scheme%22%3A%22file%22%2C%22authority%22%3A%22%22%2C%22path%22%3A%22%2FUsers%2Ftujiiprince%2Fdevelop%2Fpackages_fork%2Fflutter_native_timezone%2Fandroid%2Fbuild.gradle%22%2C%22query%22%3A%22%22%2C%22fragment%22%3A%22%22%7D%2C%22pos%22%3A%7B%22line%22%3A30%2C%22character%22%3A8%7D%7D%5D%2C%2259833c6d-ef6f-4aec-8ca5-d1739b0c5a72%22%5D "Go to definition") and [`targetCompatibility`](command:_github.copilot.openSymbolFromReferences?%5B%22%22%2C%5B%7B%22uri%22%3A%7B%22scheme%22%3A%22file%22%2C%22authority%22%3A%22%22%2C%22path%22%3A%22%2FUsers%2Ftujiiprince%2Fdevelop%2Fpackages_fork%2Fflutter_native_timezone%2Fandroid%2Fbuild.gradle%22%2C%22query%22%3A%22%22%2C%22fragment%22%3A%22%22%7D%2C%22pos%22%3A%7B%22line%22%3A31%2C%22character%22%3A8%7D%7D%5D%2C%2259833c6d-ef6f-4aec-8ca5-d1739b0c5a72%22%5D "Go to definition") to Java 1.8.
- Configured [`kotlinOptions`](command:_github.copilot.openSymbolFromReferences?%5B%22%22%2C%5B%7B%22uri%22%3A%7B%22scheme%22%3A%22file%22%2C%22authority%22%3A%22%22%2C%22path%22%3A%22%2FUsers%2Ftujiiprince%2Fdevelop%2Fpackages_fork%2Fflutter_native_timezone%2Fandroid%2Fbuild.gradle%22%2C%22query%22%3A%22%22%2C%22fragment%22%3A%22%22%7D%2C%22pos%22%3A%7B%22line%22%3A34%2C%22character%22%3A4%7D%7D%5D%2C%2259833c6d-ef6f-4aec-8ca5-d1739b0c5a72%22%5D "Go to definition") to set [`jvmTarget`](command:_github.copilot.openSymbolFromReferences?%5B%22%22%2C%5B%7B%22uri%22%3A%7B%22scheme%22%3A%22file%22%2C%22authority%22%3A%22%22%2C%22path%22%3A%22%2FUsers%2Ftujiiprince%2Fdevelop%2Fpackages_fork%2Fflutter_native_timezone%2Fandroid%2Fbuild.gradle%22%2C%22query%22%3A%22%22%2C%22fragment%22%3A%22%22%7D%2C%22pos%22%3A%7B%22line%22%3A35%2C%22character%22%3A8%7D%7D%5D%2C%2259833c6d-ef6f-4aec-8ca5-d1739b0c5a72%22%5D "Go to definition") to 1.8.
- Ensured consistent JVM target version for both Java and Kotlin compilation tasks to resolve compatibility issues.
- Updated flutter_native_timezone dependency in pubspec.yaml to use the custom Git repository at https://github.com/tujii/flutter_native_timezone.git.
- Ensured compatibility with the required Kotlin Gradle plugin version.
- Addressed JVM target compatibility issues by setting both Java and Kotlin targets to the same version.
@Mohamedghaly140
Copy link

when this could be merged !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants