Use idiomatic Effect time and random in orchestration#2599
Closed
cursor[bot] wants to merge 3 commits intomainfrom
Closed
Use idiomatic Effect time and random in orchestration#2599cursor[bot] wants to merge 3 commits intomainfrom
cursor[bot] wants to merge 3 commits intomainfrom
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Date/Date.now()usage withDateTime.now, including command timing metrics and rejected receipt timestamps.crypto.randomUUID()withRandom.nextUUIDv4.@effect/vitestcoverage for deterministic random seeding and TestClock-backed rejected receipt timestamps.Why
These changes keep orchestration behavior injectable and testable through Effect services instead of relying on global time/random sources.
UI Changes
Not applicable.
Checklist
Note
Replace native
Dateandcrypto.randomUUIDwith Effect time and random in orchestrationOrchestrationEngine.ts(read model init, queue envelopestartedAtMs, metrics durations, rejected receiptacceptedAt) now useDateTime.nowvia Effect instead ofDate.now()/new Date().toISOString().decider.tsnow useRandom.nextUUIDv4via the newmakeEventBaseEffect function instead ofcrypto.randomUUID.TestClockand seededRandom, with new tests verifying deterministic output inOrchestrationEngine.clock.test.tsanddecider.random.test.ts.Macroscope summarized 41737ab.